sonic-config-engine uses libswsscommon instead of swsssdk#6406
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom Jan 20, 2021
Merged
sonic-config-engine uses libswsscommon instead of swsssdk#6406qiluo-msft merged 3 commits intosonic-net:masterfrom
qiluo-msft merged 3 commits intosonic-net:masterfrom
Conversation
qiluo-msft
force-pushed
the
qiluo/configcommon
branch
from
13c8a96 to
7cf8f9f
Compare
lguohan
reviewed
Jan 10, 2021
Collaborator
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
can you check vs test failure?
Collaborator
Author
|
Retest vs please |
Collaborator
|
looks like vstest failed again. does not seem to be random event, need investigation. |
Collaborator
Author
|
ACK, noticing the bug and working on it. |
Signed-off-by: Qi Luo <[email protected]>
Includes commits: ``` 2f79bb4 2021-01-16 | Fix ConfigDBPipeConnector.get_config() implementation (sonic-net#446) [Qi Luo] fc64e3a 2021-01-12 | [dbconnector] protect db information with mutex (sonic-net#423) [Ying Xie] e8a03de 2021-01-12 | [ci]: use sonicbld pool (sonic-net#445) [lguohan] ```
qiluo-msft
force-pushed
the
qiluo/configcommon
branch
from
7cf8f9f to
4b8a45e
Compare
jleveque
approved these changes
Jan 19, 2021
daall
pushed a commit
that referenced
this pull request
Jan 22, 2021
**- Why I did it** swsssdk will be deprecated. Migrate sonic-config-engine to use libswsscommon library instead **- How to verify it** Unit test
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
swsssdk will be deprecated. Migrate sonic-config-engine to use libswsscommon library instead
- How I did it
- How to verify it
Unit test
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)