Skip to content

Enable rsyslogd notify mode for supervisord logs in docker container #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdosi merged 2 commits into from
Jan 1, 2021
Merged

Enable rsyslogd notify mode for supervisord logs in docker container #6298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
715f6bb
Enable the notify mode of rsyslogd imfile module used for supervisord
abdosi Dec 30, 2020
4ac40ad
Merge remote-tracking branch 'upstream/master' into feature_reset
abdosi Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions dockers/docker-base/etc/rsyslog.d/supervisor.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
$ModLoad imfile

$InputFileName /var/log/supervisor/supervisord.log
$InputFileTag supervisord
$InputFileStateFile state-supervisor
$InputFileSeverity info
$InputFileFacility local0
$InputFilePersistStateInterval 1
$InputRunFileMonitor
module(load="imfile") #By default notify mode
Copy link
Copy Markdown
Contributor

@hui-ma hui-ma Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please explain why this file format/style is changed? And why did the previous specify polling mode? Not seeing it in the config. It is default in the old format as well? Thanks!

Copy link
Copy Markdown
Contributor Author

@abdosi abdosi Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hui-ma yes old semantics of rsyslogd default to polling mode. Rsyslogd document recommends to use notify mode and new semantic going forward

Copy link
Copy Markdown
Contributor

@hui-ma hui-ma Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@jleveque jleveque Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply due to the holidays, but I wonder if we should explicitly set mode="inotify" just in case the default mode were ever to change.

Copy link
Copy Markdown
Contributor Author

@abdosi abdosi Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jleveque . PR #6351 has the change.

$WorkDirectory /var/log/supervisor
# Start Monitoring the file
input(type="imfile"
File="/var/log/supervisor/supervisord.log"
Tag="supervisord"
Severity="info"
Facility="local0"
PersistStateInterval="1")