[init_cfg]: allow enable/disable swss/teamd/syncd services#6291
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 28, 2020
Merged
[init_cfg]: allow enable/disable swss/teamd/syncd services#6291lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
swss/teamd/syncd services were changed to always enabled in commit fad481e as a workaround for not letting hostcfgd start service during the bootup process. commit 317a4b3 introduce wait till full system bootup before updating feature states in hostcfgd. Thus, workaround introduced in commit fad481e can be removed Signed-off-by: Guohan Lu <lguohan@gmail.com>
Contributor
|
@lguohan show we need to revert hostcfgd and sonic-util changes also ? |
Collaborator
Author
|
retest vsimage please |
Collaborator
Author
|
hostcfgd is fine, I think we can revert some of the portion that is on sonic-utilties |
jleveque
approved these changes
Dec 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
- Why I did it
swss/teamd/syncd services were changed to always enabled
in commit fad481e as a workaround
for not letting hostcfgd start service during the bootup process.
commit 317a4b3 introduce
wait till full system bootup before updating feature states in hostcfgd.
Thus, workaround introduced in commit fad481e can be removed
- How I did it
change teamd/swss/syncd to enabled state.
- How to verify it
check if hostcfgd update feature state after system fully bootup.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)