[sonic-config-engine] Pin 'importlib-resources' package to v3.3.1 for Python 2#6288
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 24, 2020
jleveque:pin_py2_importlib-resources
Merged
[sonic-config-engine] Pin 'importlib-resources' package to v3.3.1 for Python 2#6288lguohan merged 1 commit intosonic-net:masterfrom jleveque:pin_py2_importlib-resources
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:pin_py2_importlib-resources
Conversation
tahmed-dev
approved these changes
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
importlib-resources v4.0.0 was released today (2020-12-23) and drops support for Python 2. This caused the sonic-config-engine Python 2 wheel build to fail.
Reference: https://pypi.org/project/importlib-resources/
Example failure:
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)