DellEMC: Z9332f change SFP detection logic#6261
Merged
jleveque merged 2 commits intosonic-net:masterfrom Jan 6, 2021
Merged
Conversation
Contributor
Author
|
retest vsimage please |
3 similar comments
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
Team, Can you review this PR?. |
Contributor
Author
|
@jleveque Can you please help to review/merge this PR?. |
jleveque
approved these changes
Jan 6, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 9, 2021
- Dynamically change EEPROM driver based on media type. - Otherwise, EEPROM INFO and DOM INFO might not be fetched properly and will result in erroneous output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
Changed the optoe driver by reading optic EEPROM byte
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
UT:
z9332f_sfp_detection_logic_UT.txt
- A picture of a cute animal (not mandatory but encouraged)