[multi-asic][vs]: Update topology script to retrieve hwsku from minigraph#6219
Merged
SuvarnaMeenakshi merged 5 commits intosonic-net:masterfrom Feb 19, 2021
Merged
Conversation
information from minigraph if hwsku information is not available in config_db. Fix clean up of interfaces in msft_multi_asic_vs hwsku topology script. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
judyjoseph
reviewed
Jan 11, 2021
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
Author
|
retest vsimage please |
1 similar comment
Contributor
Author
|
retest vsimage please |
Contributor
Author
|
retest this please |
in config_db. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
judyjoseph
reviewed
Feb 2, 2021
If HWSKU is not available in config_db and minigraph is not available, exit with hwsku not found message. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
judyjoseph
previously approved these changes
Feb 4, 2021
start also fails. Set interface mtu to 9100. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
abdosi
reviewed
Feb 8, 2021
| HWSKU=`sonic-cfggen -d -v 'DEVICE_METADATA["localhost"]["hwsku"]' 2>&1` | ||
| if [[ $? -ne 0 || HWSKU == "" ]]; then | ||
| if [[ -f "/etc/sonic/minigraph.xml" ]]; then | ||
| HWSKU=`sonic-cfggen -m /etc/sonic/minigraph.xml -v "DEVICE_METADATA['localhost']['hwsku']" 2>&1` |
Contributor
There was a problem hiding this comment.
we can add this logic in function instead of duplicating it for start/stop
Contributor
Author
There was a problem hiding this comment.
Updated as suggested.
minigraph.xml as per review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
abdosi
approved these changes
Feb 19, 2021
judyjoseph
approved these changes
Feb 19, 2021
abdosi
pushed a commit
that referenced
this pull request
Feb 26, 2021
…raph (#6219) Update topology script to retrieve hwsku from minigraph if hwsku information is not available in config_db. Fix clean up of interfaces in msft_multi_asic_vs hwsku topology script. - Why I did it When bringing up multi-asic VS switch, topology service is started during boot up. Topology service starts a shell script which runs the topology script present in /usr/share/sonic/device// directory. To invoke hwsku specific script, the topology script tries to retrieve hwsku information from config_db. During initial boot up config_db might not be populated. In order to start topology service before config_db is updated, update topology script to get hwsku information from minigraph.xml if it is available. This will be helpful to bring up multi-asic VS testbed by loading minigraph and starting topology service. - How I did it Update topology.sh script to retrieve hwsku information from minigraph.xml. Fix clean up function on msft_multi_asic_vs toplogy script. - How to verify it single-asic VS - no change; topology service is only enabled for multi-asic VS. multi-asic VS - Bring up multi-asic VS image, copy minigraph to vs image, start topology service. Topology service should be successful. to test clean up function fix, start topology service - make sure interfaces are created and moved to the right namespaces. stop topology service - make sure namespace do not have any interface and all front end interfaces are present in default namespace.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…raph (sonic-net#6219) Update topology script to retrieve hwsku from minigraph if hwsku information is not available in config_db. Fix clean up of interfaces in msft_multi_asic_vs hwsku topology script. - Why I did it When bringing up multi-asic VS switch, topology service is started during boot up. Topology service starts a shell script which runs the topology script present in /usr/share/sonic/device// directory. To invoke hwsku specific script, the topology script tries to retrieve hwsku information from config_db. During initial boot up config_db might not be populated. In order to start topology service before config_db is updated, update topology script to get hwsku information from minigraph.xml if it is available. This will be helpful to bring up multi-asic VS testbed by loading minigraph and starting topology service. - How I did it Update topology.sh script to retrieve hwsku information from minigraph.xml. Fix clean up function on msft_multi_asic_vs toplogy script. - How to verify it single-asic VS - no change; topology service is only enabled for multi-asic VS. multi-asic VS - Bring up multi-asic VS image, copy minigraph to vs image, start topology service. Topology service should be successful. to test clean up function fix, start topology service - make sure interfaces are created and moved to the right namespaces. stop topology service - make sure namespace do not have any interface and all front end interfaces are present in default namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update topology script to retrieve hwsku from minigraph
if hwsku information is not available in config_db.
Fix clean up of interfaces in msft_multi_asic_vs hwsku
topology script.
Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com
- Why I did it
When bringing up multi-asic VS switch, topology service is started during boot up.
Topology service starts a shell script which runs the topology script present in /usr/share/sonic/device// directory. To invoke hwsku specific script, the topology script tries to retrieve hwsku information from config_db.
During initial boot up config_db might not be populated. In order to start topology service before config_db is updated,
update topology script to get hwsku information from minigraph.xml if it is available.
This will be helpful to bring up multi-asic VS testbed by loading minigraph and starting topology service.
- How I did it
- How to verify it
stop topology service - make sure namespace do not have any interface and all front end interfaces are present in default namespace.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)