[hostimage] No need to mark packages as auto since all debootstrap installed packages are fundamental and will not be removed#6159
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 10, 2020
Conversation
packages are fundamental and will not be removed
Collaborator
Author
|
Retest vsimage please |
xumia
approved these changes
Dec 10, 2020
3 tasks
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Dec 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Originally this line is used to mark all previously installed packages (deboostrap installed) as auto, so later if no other packages depend on anyone of them, it will be auto removed. Seems we gained little from this line, so let's remove it.
- How I did it
- How to verify it
Check the build log after
sudo LANG=C chroot ./fsroot apt-get -y autoremoveand the removed packages are unchanged.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)