IXS7215:fix for dynamic changes reading DOM and LED#6136
Merged
lguohan merged 2 commits intosonic-net:masterfrom Dec 11, 2020
Merged
IXS7215:fix for dynamic changes reading DOM and LED#6136lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
- clean up corner condition when SDK reset and SFP's move
|
This pull request introduces 8 alerts when merging d6171af into af357f3 - view on LGTM.com new alerts:
|
Contributor
Author
|
retest broadcom please |
Collaborator
|
can you fix lgtm alerts? |
Contributor
Author
|
I fixed for LGTM alerts immediately after creating this PR three days ago ( ce100d9 ). There are no new alerts with this PR. |
lguohan
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
fix rare corner conditions
system leds - in some conditions when CPSS has been reset the gpio driver led state it controls should be reset also
dom support in sfp - change reading of SFP+ dom capability from init routine to dynamic check - works any daemon
- How I did it
- How to verify it
combinations of “sudo systemctl restart swss” “sudo systemctl restart syncd” and swapping SFP+ types around
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)