[docker-syncd-*-rpc]: Remove sysctl setting which is not used anymore#611
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom May 18, 2017
pavel-shirshov:pavelsh/remove_sysctl
Merged
[docker-syncd-*-rpc]: Remove sysctl setting which is not used anymore#611pavel-shirshov merged 1 commit intosonic-net:masterfrom pavel-shirshov:pavelsh/remove_sysctl
pavel-shirshov merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/remove_sysctl
Conversation
lguohan
approved these changes
May 18, 2017
lguohan
pushed a commit
that referenced
this pull request
Sep 5, 2019
Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (#598) [config]: fix the runtime error of the 'show line' command (#595) (#596) Revert "Removed 'show interfaces alias'. (#412)" (#603) [debug][undebug] Rework of CLI for BGP (#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (#600) [config] Add commands to add/remove DHCP server address from a VLAN (#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (#604) [neighbor_advertise]: Use the existing MIRROR ACL table (#605) Read config DB for running interface(s) and display per port/interface (#594) [fast/warm reboot] kill radv docker before stopping BGP (#608) [config] Add commands for adding/removing syslog servers (#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (#607) [Command Reference] Add config commands for DHCP relay destination address (#610) [config] Add commands for adding/removing NTP servers (#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (#612) [neighbor advertiser] try getting vlan addresses from o.s first (#613) [show] Add command 'show runningconfiguration syslog' (#617) [show] Add command 'show runningconfig ntp' (#620) Added check to config syslog del to verify if ip address was configured. (#622) [fast-reboot] Check if ASIC config has changed before warm reboot (#621) Signed-off-by: Danny Allen [email protected]
sridhar-ravindran
pushed a commit
to sridhar-ravindran/sonic-buildimage
that referenced
this pull request
Sep 6, 2019
Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (sonic-net#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (sonic-net#598) [config]: fix the runtime error of the 'show line' command (sonic-net#595) (sonic-net#596) Revert "Removed 'show interfaces alias'. (sonic-net#412)" (sonic-net#603) [debug][undebug] Rework of CLI for BGP (sonic-net#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (sonic-net#600) [config] Add commands to add/remove DHCP server address from a VLAN (sonic-net#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604) [neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605) Read config DB for running interface(s) and display per port/interface (sonic-net#594) [fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608) [config] Add commands for adding/removing syslog servers (sonic-net#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607) [Command Reference] Add config commands for DHCP relay destination address (sonic-net#610) [config] Add commands for adding/removing NTP servers (sonic-net#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612) [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613) [show] Add command 'show runningconfiguration syslog' (sonic-net#617) [show] Add command 'show runningconfig ntp' (sonic-net#620) Added check to config syslog del to verify if ip address was configured. (sonic-net#622) [fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621) Signed-off-by: Danny Allen [email protected]
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Previously, we didn't allow the func_len to zero in YANG model, which conflicts with our use case. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Change the lower bound of the func_len's range. #### How to verify it Configure a locator entry in CONFIG_DB and then do a config reload. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] 202412 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
mssonicbld
added a commit
that referenced
this pull request
May 24, 2025
…D automatically (#22653) #### Why I did it src/sonic-platform-daemons ``` * 45c1582 - (HEAD -> master, origin/master, origin/HEAD) [xcvrd] Optimize module initialization performance (#611) (5 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
skr31
pushed a commit
to skr31/sonic-buildimage
that referenced
this pull request
May 25, 2025
…test HEAD automatically (sonic-net#1148) #### Why I did it src/sonic-platform-daemons ``` * 5016ded - (HEAD -> 202412, origin/202412) [xcvrd] Optimize module initialization performance (sonic-net#611) (sonic-net#16) (11 minutes ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-buildimage
that referenced
this pull request
Aug 1, 2025
mssonicbld
added a commit
that referenced
this pull request
Dec 27, 2025
… automatically (#24948) #### Why I did it src/sonic-platform-common ``` * 6ac5692 - (HEAD -> master, origin/master, origin/HEAD) [cmis] Only create CdbFwHandler if module support CDB (#611) (3 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
… automatically (sonic-net#24948) #### Why I did it src/sonic-platform-common ``` * 6ac5692 - (HEAD -> master, origin/master, origin/HEAD) [cmis] Only create CdbFwHandler if module support CDB (sonic-net#611) (3 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
8 tasks
yejianquan
pushed a commit
that referenced
this pull request
Feb 14, 2026
Why I did it
On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too.
when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(levent_iface_subscribe).
Since queries and changes are using same sokcet cfg->g_netlink->nl_socket, previous RTM_GETLINK dump interfaces(netlink_recv RTM_GETLINK) is impacted by the new RTM_NEWLINK messages handling process(netlink_change_cb).
About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization.
Phenomenon:
Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead
a. Fail to find eth0 and fallback to hostname.
WARNING lldp#lldpcli[29]: cannot find port eth0
lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries.
a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry
Work item tracking
Microsoft ADO 36610002:
How I did it
now sonic is using lldpd 1.0.16.
There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue #611 · lldpd/lldpd
And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa
Add this commit as a new patch for sonic to fix this issue.
How to verify it
config reload can repro this issue easily on 5640 full topology testbed.
Try run "config reload" and verify if all lldp neighbors are up.
Signed-off-by: Zhaohui Sun <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 14, 2026
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too.
when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(`levent_iface_subscribe`).
Since queries and changes are using same `sokcet cfg->g_netlink->nl_socket,` previous `RTM_GETLINK` dump interfaces(`netlink_recv RTM_GETLINK`) is impacted by the new RTM_NEWLINK messages handling process(`netlink_change_cb`).
About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization.
- Phenomenon:
1. Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead
a. Fail to find eth0 and fallback to hostname.
WARNING lldp#lldpcli[29]: cannot find port eth0
1. lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries.
a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry
##### Work item tracking
- Microsoft ADO **36610002**:
#### How I did it
now sonic is using lldpd 1.0.16.
There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue sonic-net#611 · lldpd/lldpd
And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa
Add this commit as a new patch for sonic to fix this issue.
#### How to verify it
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
config reload can repro this issue easily on 5640 full topology testbed.
Try run "config reload" and verify if all lldp neighbors are up.
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
8 tasks
mssonicbld
added a commit
that referenced
this pull request
Feb 16, 2026
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too. when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(`levent_iface_subscribe`). Since queries and changes are using same `sokcet cfg->g_netlink->nl_socket,` previous `RTM_GETLINK` dump interfaces(`netlink_recv RTM_GETLINK`) is impacted by the new RTM_NEWLINK messages handling process(`netlink_change_cb`). About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization. - Phenomenon: 1. Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead a. Fail to find eth0 and fallback to hostname. WARNING lldp#lldpcli[29]: cannot find port eth0 1. lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries. a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry ##### Work item tracking - Microsoft ADO **36610002**: #### How I did it now sonic is using lldpd 1.0.16. There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue #611 · lldpd/lldpd And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa Add this commit as a new patch for sonic to fix this issue. #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> config reload can repro this issue easily on 5640 full topology testbed. Try run "config reload" and verify if all lldp neighbors are up. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
… automatically (sonic-net#24948) #### Why I did it src/sonic-platform-common ``` * 6ac5692 - (HEAD -> master, origin/master, origin/HEAD) [cmis] Only create CdbFwHandler if module support CDB (sonic-net#611) (3 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
Why I did it
On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too.
when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(levent_iface_subscribe).
Since queries and changes are using same sokcet cfg->g_netlink->nl_socket, previous RTM_GETLINK dump interfaces(netlink_recv RTM_GETLINK) is impacted by the new RTM_NEWLINK messages handling process(netlink_change_cb).
About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization.
Phenomenon:
Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead
a. Fail to find eth0 and fallback to hostname.
WARNING lldp#lldpcli[29]: cannot find port eth0
lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries.
a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry
Work item tracking
Microsoft ADO 36610002:
How I did it
now sonic is using lldpd 1.0.16.
There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue sonic-net#611 · lldpd/lldpd
And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa
Add this commit as a new patch for sonic to fix this issue.
How to verify it
config reload can repro this issue easily on 5640 full topology testbed.
Try run "config reload" and verify if all lldp neighbors are up.
Signed-off-by: Zhaohui Sun <[email protected]>
Signed-off-by: Feng Pan <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 11, 2026
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too.
when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(`levent_iface_subscribe`).
Since queries and changes are using same `sokcet cfg->g_netlink->nl_socket,` previous `RTM_GETLINK` dump interfaces(`netlink_recv RTM_GETLINK`) is impacted by the new RTM_NEWLINK messages handling process(`netlink_change_cb`).
About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization.
- Phenomenon:
1. Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead
a. Fail to find eth0 and fallback to hostname.
WARNING lldp#lldpcli[29]: cannot find port eth0
1. lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries.
a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry
##### Work item tracking
- Microsoft ADO **36610002**:
#### How I did it
now sonic is using lldpd 1.0.16.
There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue sonic-net#611 · lldpd/lldpd
And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa
Add this commit as a new patch for sonic to fix this issue.
#### How to verify it
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
config reload can repro this issue easily on 5640 full topology testbed.
Try run "config reload" and verify if all lldp neighbors are up.
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
Signed-off-by: Sonic Build Admin <[email protected]>
#### A picture of a cute animal (not mandatory but encouraged)
8 tasks
mssonicbld
added a commit
that referenced
this pull request
Mar 16, 2026
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too. when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(`levent_iface_subscribe`). Since queries and changes are using same `sokcet cfg->g_netlink->nl_socket,` previous `RTM_GETLINK` dump interfaces(`netlink_recv RTM_GETLINK`) is impacted by the new RTM_NEWLINK messages handling process(`netlink_change_cb`). About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization. - Phenomenon: 1. Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead a. Fail to find eth0 and fallback to hostname. WARNING lldp#lldpcli[29]: cannot find port eth0 1. lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries. a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry ##### Work item tracking - Microsoft ADO **36610002**: #### How I did it now sonic is using lldpd 1.0.16. There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue #611 · lldpd/lldpd And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa Add this commit as a new patch for sonic to fix this issue. #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> config reload can repro this issue easily on 5640 full topology testbed. Try run "config reload" and verify if all lldp neighbors are up. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> Signed-off-by: Sonic Build Admin <[email protected]> #### A picture of a cute animal (not mandatory but encouraged)
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
… automatically (#24948) #### Why I did it src/sonic-platform-common ``` * 6ac5692 - (HEAD -> master, origin/master, origin/HEAD) [cmis] Only create CdbFwHandler if module support CDB (#611) (3 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
Why I did it
On 5640 full topology testbed, during system boots up, 457(456 Ethernet + eth0) interfaces are booting up, lldpd is initializing too.
when lldpd initializing, it will send RTM_GETLINK dump to get all interfaces, but during this period, some new interfaces are boots up, lldpd subscribes async notification of netlink update(levent_iface_subscribe).
Since queries and changes are using same sokcet cfg->g_netlink->nl_socket, previous RTM_GETLINK dump interfaces(netlink_recv RTM_GETLINK) is impacted by the new RTM_NEWLINK messages handling process(netlink_change_cb).
About 200+ interfaces are missing in lldp neighbor. Only 200+ interfaces exist which have RTM_NEWLINK arrived after lldpd initialization.
Phenomenon:
Incorrect Chassis ID - Chassis ID being incorrect, should be mac but show hostname instead
a. Fail to find eth0 and fallback to hostname.
WARNING lldp#lldpcli[29]: cannot find port eth0
lldpcli config failure - The port is up already, but later lldp cannot find the port, hence missing port up events and never be able to recover. The symptom will be both sides are missing lldp entries.
a. <11>2026-02-05T04:18:42.052245+00:00 ATL21-0101-0014-12BT0 ERR lldp#lldpmgrd[38]: Command failed '['lldpcli', 'configure', 'ports', 'Ethernet501', 'lldp', 'portidsubtype', 'local', 'etp63f', 'description', 'ATL210101580129:A1.PORT8']': 2026-02-05T04:18:42 [WARN/lldpctl] cannot find port Ethernet501#012 - command was failed 6 times, disabling retry
Work item tracking
Microsoft ADO 36610002:
How I did it
now sonic is using lldpd 1.0.16.
There is a known issue in lldpd community: In some cases lldpd cannot get all interfaces · Issue #611 · lldpd/lldpd
And it's fixed, but no tag for 1.0.16 :daemon/netlink: use a different socket for changes and queries · lldpd/lldpd@88fe3fa
Add this commit as a new patch for sonic to fix this issue.
How to verify it
config reload can repro this issue easily on 5640 full topology testbed.
Try run "config reload" and verify if all lldp neighbors are up.
Signed-off-by: Zhaohui Sun <[email protected]>
Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.