[relay]: Prevent Buffer Overrun Of Malformed DHCP Packet#6057
Merged
tahmed-dev merged 3 commits intosonic-net:masterfrom Dec 12, 2020
Merged
Conversation
tahmed-dev
force-pushed
the
taahme/dhcp-relay-avoid-buffer-overrun
branch
4 times, most recently
from
b5dd36c to
a589f00
Compare
jleveque
suggested changes
Dec 1, 2020
tahmed-dev
force-pushed
the
taahme/dhcp-relay-avoid-buffer-overrun
branch
from
a589f00 to
ed6c731
Compare
The add/strip relay agent options do not take into account the buffer length and so it is possible to overrun the buffer. The issue will result in contents from previous packet being added to the current one. signed-off-by: Tamer Ahmed <[email protected]>
tahmed-dev
force-pushed
the
taahme/dhcp-relay-avoid-buffer-overrun
branch
from
ed6c731 to
513c3a3
Compare
jleveque
approved these changes
Dec 10, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
LGTM. Should this patch be upstreamed?
Contributor
Author
I guess so. There could be cross packets information leak. |
ghost
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add/strip relay agent options do not take into account the buffer
length and so it is possible to overrun the buffer. The issue will
result in contents from previous packet being added to the current one.
closes #6052
resolves #6052
signed-off-by: Tamer Ahmed [email protected]
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)