[L2 switch mode] Update l2switch.j2 template#5981
Conversation
| "{{ key }}": { | ||
| "alias": "{{ value.alias }}", | ||
| "lanes": "{{ value.lanes }}", | ||
| {%- for keyPort,valuePort in value.items() %} |
There was a problem hiding this comment.
keyPort [](start = 20, length = 7)
If keyPort == 'admin_status', is it a problem? #Closed
There was a problem hiding this comment.
Added check to resolve the scenario with admin_status exists.
| "{{ key }}": { | ||
| "alias": "{{ value.alias }}", | ||
| "lanes": "{{ value.lanes }}", | ||
| {%- for keyPort,valuePort in value.items() %} |
There was a problem hiding this comment.
, [](start = 27, length = 1)
Add a blank after ,. Also some more occurrences in the whole file. #Closed
I think I understand your point: different device types have different sources of port configuration data, and it would be better to capture the difference. However, in this particular test, the data source is explicitly specified (tests/t0-sample-port-config.ini). So only changing the device type cannot test out the sources of port configuration data, and in this test setup, it does not seem the source of port configuration data could follow the |
|
retest vsimage please |
- Why I did it The l2switch.j2 template does not include all fields for PORT. This could be incompatible with the 201911 image or later. - How I did it Update l2switch.j2 template and add a unit test.
- Why I did it The l2switch.j2 template does not include all fields for PORT. This could be incompatible with the 201911 image or later. - How I did it Update l2switch.j2 template and add a unit test.
- Why I did it
The l2switch.j2 template does not include all fields for PORT. This could be incompatible with the 201911 image or later.
- How I did it
Update l2switch.j2 template and add a unit test.
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)