[DellEMC Z9332f] Platform API 2.0 Support and bug fixing#5958
[DellEMC Z9332f] Platform API 2.0 Support and bug fixing#5958jleveque merged 7 commits intosonic-net:masterfrom
Conversation
1) Add platform infra to support 2.0 APi
2) Bug fixing for 9332 known issues
|
This pull request introduces 34 alerts when merging 4bc16a8 into 2fe79c2 - view on LGTM.com new alerts:
|
|
This pull request introduces 23 alerts when merging 798b608 into bbbd94f - view on LGTM.com new alerts:
|
|
All the critical and relevant lgtm issues are fixed. |
|
This pull request introduces 23 alerts when merging 167d56f into 61419f5 - view on LGTM.com new alerts:
|
daall
left a comment
There was a problem hiding this comment.
Please fix the LGTM warnings!
|
Some LGTM alerts may be false alarms (like "Wrong number of arguments in a class instantiation") because LGTM references the incorrect vendor's platform API files. However, some of these can be fixed, like:
|
|
This pull request introduces 18 alerts when merging 0b026e6 into 3b04da9 - view on LGTM.com new alerts:
|
|
This pull request introduces 9 alerts when merging f59307f into 43a32e6 - view on LGTM.com new alerts:
|
platform/broadcom/sonic-platform-modules-dell/z9332f/sonic_platform/__init__.py
Outdated
Show resolved
Hide resolved
|
This pull request introduces 9 alerts when merging c5270c2 into 275c5cf - view on LGTM.com new alerts:
|
platform/broadcom/sonic-platform-modules-dell/z9332f/sonic_platform/sfp.py
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-dell/z9332f/sonic_platform/sfp.py
Show resolved
Hide resolved
|
This pull request introduces 7 alerts when merging 3bb0121 into 275c5cf - view on LGTM.com new alerts:
|
|
@srideepDell: Thanks for working to clean up those LGTM alerts! |
|
retest vs please |
Thanks for your guidance Joe |
|
retest vs please |
- Why I did it
Add platform infra to support 2.0 API
Bug fixing for 9332 known issues
- How I did it
Change to platform specific code under platform directory specific to Z9332
- How to verify it
verified on Z9332 platform logs attached
x
- Description for the changelog
1) Add platform infra to support 2.0 API
2) Bug fixing for 9332 known issues
- A picture of a cute animal (not mandatory but encouraged)