[celestica dx010] comment out the initialization of PCA9541#5891
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 11, 2020
Merged
[celestica dx010] comment out the initialization of PCA9541#5891lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
The original code tried to initialize PCA9541 without having the driver loaded. As result the initialization didn't take effect. Recently PCA9541 driver was added to the kernel and since then the initialization takes effect and has negatively impacted the platform stability. Commenting the initialization code out to restore the original behavior while analyzing further. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
approved these changes
Nov 11, 2020
3 tasks
lguohan
approved these changes
Nov 11, 2020
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Dec 24, 2020
Remove the unused codes addressed in #5891 on Dx010 platform.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#5891) The original code tried to initialize PCA9541 without having the driver loaded. As result the initialization didn't take effect. Recently PCA9541 driver was added to the kernel and since then the initialization takes effect and has negatively impacted the platform stability. Commenting the initialization code out to restore the original behavior while analyzing further. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
The original code tried to initialize PCA9541 without having the driver loaded. As result the initialization didn't take effect.
Recently PCA9541 driver was added to the kernel and since then the initialization takes effect and has negatively impacted the
platform stability.
- How I did it
Commenting the initialization code out to restore the original behavior while analyzing further.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Manually made the change on a device subject to the issue. Reboot the device and the device becomes healthy. Particularly, able to access psu status. And can run test_link_flap without triggering sanity check failures.
- Which release branch to backport (provide reason below if selected)