Skip to content

[Mellanox] SN4410 support#5778

Merged
jleveque merged 11 commits intosonic-net:masterfrom
vadymhlushko-mlnx:sn4410_bring_up
Nov 24, 2020
Merged

[Mellanox] SN4410 support#5778
jleveque merged 11 commits intosonic-net:masterfrom
vadymhlushko-mlnx:sn4410_bring_up

Conversation

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 2, 2020 •
edited
Loading

Signed-off-by: Vadym Hlushko vadymh@nvidia.com

- Why I did it

Add support for Mellanox Spectrum-3 based 100GbE/400GbE 1U. 24 QSFP-DD28 and 8 QSFP-DD ports

- How I did it

Added all config files that are needed to support SN4410.

- How to verify it

Need to check:

  • if there are no errors in logs via serial connection
  • if there are no errors in logs via ssh connection
  • interfaces creation
  • basic switching
  • basic routing

- Which release branch to backport (provide reason below if selected)

  • 201911
  • master

- Description for the changelog

Added files like for other platforms (e.g. SN4700) under - sonic-buildimage/device/mellanox/x86_64-mlnx_msn4410-r0 directory.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 2, 2020

This pull request introduces 5 alerts when merging 6d660d504becf3d8d26d4c29ed5a6df3dcd62377 into 1be9c4a - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Testing equality to None
  • 1 for Unused import
  • 1 for Unreachable code

@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 3, 2020

retest this please

@volodymyrsamotiy
Copy link
Copy Markdown
Collaborator

volodymyrsamotiy commented Nov 3, 2020

Should be merged after #5767 is merged to master

@keboliu
Copy link
Copy Markdown
Collaborator

keboliu commented Nov 4, 2020

retest this please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Nov 6, 2020

retest baseimage please

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 8, 2020

@vadymhlushko-mlnx please handle LGTM issues

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 10, 2020

retest mellanox please

@lguohan lguohan requested a review from jleveque November 16, 2020 12:27
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Nov 16, 2020

any missing data we need for a platform?

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 16, 2020

any missing data we need for a platform?

all should be there but I didnt merge as sonic-mgmt is not fully updated. so waiting for this PR to be available first and then we can merge both.

liat-grozovik
liat-grozovik requested changes Nov 16, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing pcied file

@vadymhlushko-mlnx
[SN4410] added symlinks to common files from SN4700 directory
d322d02 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] adapted to SN4410 - 'sai.profile' and 'sai_4700.xml' files f…
7192206 
…rom SN4700 directory

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] adatped to SN4410 - 'sfputil.py' file from SN4700 directory
56dbdc6 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] added symlink to 'sensors.conf' file
f694dc3 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] added 'default_sku' file
53d2ee5 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] added 'platform_components.json' file
e9579f9 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] fixed symlinks to 'buffers_defaults_t*' files
b71adf3 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[Mellanox] Added support for SN4410 platform - chassis.py, device_dat…
d365566 
…a.py, psu.py, thermal.py

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] fixed LGTM alerts
cbac4ad 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
[SN4410] added symlink to pcie.yaml
6c29bfe 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 18, 2020

retest vsimage please

1 similar comment
@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 19, 2020

retest vsimage please

liat-grozovik
liat-grozovik reviewed Nov 22, 2020
View reviewed changes
platform/mellanox/mlnx-platform-api/sonic_platform/thermal.py Outdated
]
)
},
# 4410
Copy link
Copy Markdown
Collaborator

@liat-grozovik liat-grozovik Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymhlushko-mlnx why this one was added in the middle and not on the end?
BTW, this list is only for non-default systems? i dont see sn4700 and i wonder if this should be added.

Copy link
Copy Markdown
Contributor Author

@vadymhlushko-mlnx vadymhlushko-mlnx Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will commit this change to the end.

SN4700 was already added - thermal.py please check

Copy link
Copy Markdown
Contributor Author

@vadymhlushko-mlnx vadymhlushko-mlnx Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 22, 2020

@vadymhlushko-mlnx please provide the reference to the sonic-mgmt with the sensor test.

@vadymhlushko-mlnx
[SN4410] fixed an order thermal_profile_list
31a7dbe 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Copy Markdown
Contributor Author

vadymhlushko-mlnx commented Nov 23, 2020

@vadymhlushko-mlnx please provide the reference to the sonic-mgmt with the sensor test.

@liat-grozovik could you please clarify - what should I provide?

@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Nov 24, 2020

@jleveque any further comment? let me know if i missed a file :-)

jleveque
jleveque approved these changes Nov 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleveque jleveque merged commit 5038730 into sonic-net:master Nov 24, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@vadymhlushko-mlnx @santhosh-kt
[Mellanox] SN4410 support (sonic-net#5778)
603bdf7 
Add support for Mellanox Spectrum-3 based 100GbE/400GbE 1U. 24 QSFP-DD28 and 8 QSFP-DD ports

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

+1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕ Platform: Mellanox

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vadymhlushko-mlnx @volodymyrsamotiy @keboliu @lguohan @liat-grozovik @jleveque