[files/build/versions]: support reproduceable build for git#5774
Merged
xumia merged 2 commits intosonic-net:masterfrom Jan 21, 2021
liushilongbuaa:version-control-git
Merged
[files/build/versions]: support reproduceable build for git#5774xumia merged 2 commits intosonic-net:masterfrom liushilongbuaa:version-control-git
xumia merged 2 commits intosonic-net:masterfrom
liushilongbuaa:version-control-git
Conversation
jleveque
reviewed
Nov 2, 2020
qiluo-msft
reviewed
Nov 25, 2020
qiluo-msft
reviewed
Nov 25, 2020
qiluo-msft
reviewed
Nov 25, 2020
xumia
reviewed
Dec 29, 2020
xumia
reviewed
Dec 29, 2020
xumia
reviewed
Jan 5, 2021
qiluo-msft
reviewed
Jan 14, 2021
Signed-off-by: shilongliu <shilongliu@microsoft.com>
xumia
previously approved these changes
Jan 19, 2021
xumia
reviewed
Jan 19, 2021
qiluo-msft
approved these changes
Jan 21, 2021
Collaborator
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please also check with other reviewers.
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 18, 2021
…t#5774) * support reproduceable build for git clone Signed-off-by: shilongliu <shilongliu@microsoft.com> * fix Co-authored-by: shilongliu <shilongliu@microsoft.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 18, 2021
…onic-net#5774)" This reverts commit d75c290.
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jun 21, 2021
…or git (sonic-net#5774)"" This reverts commit 1cb8daf.
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jun 21, 2021
…onic-net#5774)" This reverts commit 547aa9b.
qiluo-msft
added a commit
that referenced
this pull request
Jun 21, 2021
* Revert "fix" This reverts commit 93585b0. * Revert "Version control git (#6562)" This reverts commit 52b8775. * Revert "Revert "[files/build/versions]: support reproduceable build for git (#5774)"" This reverts commit 1cb8daf. * Revert "[files/build/versions]: support reproduceable build for git (#5774)" This reverts commit 547aa9b.
liushilongbuaa
added
Approved for 202106 Branch
and removed
Approved for 202106 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Some component's make process need thirdparty source file which is downloaded by "git clone", not using a specific commit. When source file is changed, Build process may fail.
- How I did it
- How to verify it
'files/build/versions/versions-git.log' records some infomation.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Control thirdparty source code version used by 'git clone'
- A picture of a cute animal (not mandatory but encouraged)