[Dockers]: Manage all Docker containers with Supervisord#573
Merged
jleveque merged 17 commits intosonic-net:masterfrom May 8, 2017
jleveque:supervisorize_dockers
Merged
[Dockers]: Manage all Docker containers with Supervisord#573jleveque merged 17 commits intosonic-net:masterfrom jleveque:supervisorize_dockers
jleveque merged 17 commits intosonic-net:masterfrom
jleveque:supervisorize_dockers
Conversation
added 17 commits
May 4, 2017 06:50
- Also now installing supervisor package in docker-base so that supervisor is available in all docker containers and can be used as a standard, so removed supervisor installation from dockers built on top of docker-base. - Capped supervisor log max filesize to 1MB and max of 2 rotated files. We shouldn't need more because rsyslog should be constantly monitoring changes to these files and appending them to syslog. - Also some unrelated minor cleanup in docker-ptf Dockerfile
…iserver-mlnx; update .gitignore
jleveque
requested review from
lguohan,
marian-pritsak,
pavel-shirshov,
qiluo-msft,
stcheng and
taoyl-ms
lguohan
reviewed
May 8, 2017
|
|
||
| trap clean_up SIGTERM SIGKILL | ||
|
|
||
| service syncd start |
Collaborator
There was a problem hiding this comment.
syncd still managed by service not supervisord?
Contributor
Author
There was a problem hiding this comment.
syncd has a complex init script. I don't have much experience with syncd operations and testing methods, so I figured this task would be best left to someone with more experience. Init script functionality just needs to be ported into the syncd.sh script I created.
Collaborator
|
|
lguohan
approved these changes
May 8, 2017
This was referenced May 8, 2017
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* Allow decap tunnel configuration without "src_ip" Signed-off-by: Stepan Blyschak <[email protected]> * Remove overlay loopback interface when removing tunnel After tunnel removal there was still overlay loopback interface in ASIC DB. Signed-off-by: Stepan Blyschak <[email protected]> * Add more test cases to test_tunnel.py Seperate symmetric and decap tunnel test Add checks for tunnel removal Signed-off-by: Stepan Blyschak <[email protected]>
judyjoseph
added a commit
that referenced
this pull request
Mar 27, 2020
The following changes are included in this submodule advance 54b2510 [syncd] Use correct VID when GET will fail to obrain object type (#577) 59b0430 [syncd] Unlock vendor api lock if enabling diag shell (#571) 910d45e [vs] Add more logs when setting MTU on port (#576) c0d9947 [vs] Fix setting correct port mtu value (#573)
lguohan
pushed a commit
that referenced
this pull request
Apr 8, 2020
* f4d9398 2020-04-07 | [vs] Set mto only on tap device (#592) [Kamil Cudnik] * 0ad13f5 2020-04-07 | [lgtm]: add lgtm static analysis configuration (#589) [lguohan] * c961260 2020-04-07 | add swss-common-{inc,lib} to specify the prefix of swss-common library (#590) [lguohan] * 2d68abc 2020-04-06 | [syncd] Load correct global context id (#588) [Kamil Cudnik] * cd82389 2020-04-06 | Return correct error code when port is in use (#565) [Vasant Patil] * 2189c2f 2020-04-02 | [syncd] Pass correct switch RID when staring diag shell (#587) [Kamil Cudnik] * 91792db 2020-04-01 | [syncd] Fix crash during stats polling (#586) [Vitaliy Senchyshyn] * d13521e 2020-04-01 | [meta] Flush fdb entries after flush api success (#581) [Kamil Cudnik] * 54b2510 2020-03-17 | [syncd] Use correct VID when GET will fail to obrain object type (#577) [Kamil Cudnik] * 59b0430 2020-03-16 | [syncd] Unlock vendor api lock if enabling diag shell (#571) [Kamil Cudnik] * 910d45e 2020-03-16 | [vs] Add more logs when setting MTU on port (#576) [Kamil Cudnik] * c0d9947 2020-03-13 | [vs] Fix setting correct port mtu value (#573) [Kamil Cudnik]
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jan 18, 2022
d00a25bb [ci] refer 202106 branch resources rather than master branch. (sonic-net#573) Signed-off-by: Stephen Sun <[email protected]>
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 18, 2022
d00a25bb [ci] refer 202106 branch resources rather than master branch. (#573) Signed-off-by: Stephen Sun <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
Dec 20, 2024
…D automatically (#21203) #### Why I did it src/sonic-platform-daemons ``` * c61323f - (HEAD -> master, origin/master, origin/HEAD) [chassisd] Address the chassisd crash issue and add UT for it (#573) (2 days ago) [Marty Y. Lok] * 0d79916 - [chassis][psud] Move the PSU parent information generation to the loop run function from the initialization function (#576) (2 days ago) [Jianquan Ye] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Dec 22, 2024
…D automatically (#21252) #### Why I did it src/sonic-platform-daemons ``` * 291d3bb - (HEAD -> 202405, origin/202405) Take non-CMIS xcvrs out of lpmode in SFF Manager (#565) (22 hours ago) [Peter Bailey] * ef80d32 - [chassisd] Address the chassisd crash issue and add UT for it (#573) (31 hours ago) [Marty Y. Lok] ``` #### How I did it #### How to verify it #### Description for the changelog
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…D automatically (sonic-net#21203) #### Why I did it src/sonic-platform-daemons ``` * c61323f - (HEAD -> master, origin/master, origin/HEAD) [chassisd] Address the chassisd crash issue and add UT for it (sonic-net#573) (2 days ago) [Marty Y. Lok] * 0d79916 - [chassis][psud] Move the PSU parent information generation to the loop run function from the initialization function (sonic-net#576) (2 days ago) [Jianquan Ye] ``` #### How I did it #### How to verify it #### Description for the changelog
yuazhe
pushed a commit
to yuazhe/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
[202412] Code sync sonic-net/sonic-buildimage:202411 => 202412
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-buildimage
that referenced
this pull request
Aug 1, 2025
…net#573) Description On Nokia platform, slot name of Supervisor is string "A" instead of a number. Using "int" to convert it could cause issue backtrace. We should use slot value to any checking without any conversion. This will fixes sonic-net#21131 Motivation and Context Modify the _get_module_info not to convert "slot" to a string value. And also modify the code not to convert slot value to an to do any checking. Just directly use the returned value of get_slot(). Also add UT test_moduleupdater_check_slot_string() to valid it. How Has This Been Tested? Tested on 202405 branch Signed-off-by: mlok <[email protected]>
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-buildimage
that referenced
this pull request
Aug 1, 2025
…evice is in detaching mode (sonic-net#546) * Skip logging the warning, if device is in detaching mode * Add detach_info table and unittests * Fix unit tests * Increase code coverage * Remove unused header import * Fix dict get values * Increase code coverage * Increase test coverage * [SmartSwitch] Extend implementation of the DPU chassis daemon. (sonic-net#563) * Addition of DPU Chassis for thermalctld (sonic-net#564) * [stormond] Added new dynamic field 'last_sync_time' to STATE_DB (sonic-net#535) * Added new dynamic field 'last_sync_time' that shows when STORAGE_INFO for disk was last synced to STATE_DB * Moved 'start' message to actual starting point of the daemon * Added functions for formatted and epoch time for user friendly time display * Made changes per prgeor review comments * Pivot to SysLogger for all logging * Increased log level so that they are seen in syslogs * Code coverage improvement * [lag_id] Add lagid to free_list when LC absent for 30 minutes (sonic-net#542) When LC is absent for 30 minutes, the database cleanup kicks in. When LagId is released, it needs to be appended to the SYSTEM_LAG_IDS_FREE_LIST This PR works with the following 2 PRs: sonic-net/sonic-swss#3303 sonic-net#20369 Signed-off-by: mlok <[email protected]> * Fixed bug in chassisd causing incorrect number of ASICs in CHASSIS_STATE_DB (sonic-net#560) Fixed the bug in chassisd due to which incorrect number of ASICs were being pushed to CHASSIS_STATE_DB. * thermalctld: Add support for fans on non-CPU modules (sonic-net#555) * thermalctld: Add support for fans on non-CPU modules * Add module fan to unit tests * Advanced Azure pipeline to Bookworm (sonic-net#572) Description This PR advances the azure pipeline on sonic_platform_daemons from bullseye to bookworm. This fixes the issue where sonic-platform-daemons azp is having some issues due to upgrade to bookworm. See Pipelines - Run 20241210.8 logs for details. * Take non-CMIS xcvrs out of lpmode in SFF Manager (sonic-net#565) Description Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task. This is intended to work together with the change in sonic-net#20886. Motivation and Context Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode. How Has This Been Tested? Loaded an image containing this change alongside the change from sonic-net#20886 on an Arista chassis containing a Clearwater2 linecard. Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected. * Added SmartSwitch support in chassisd and enabling chassisd (sonic-net#467) Added SmartSwitch support in chassisd and enabling chassisd * [chassis][psud] Move the PSU parent information generation to the loop run function from the initialization function (sonic-net#576) Description Move the PSU parent information generation to the loop run function from the initialization function Motivation and Context Fixes sonic-net#575 How Has This Been Tested? Tested on Cisco chassis, the PHYSICAL_ENTITY_INFO|PSU * can be re-inserted after thermalctld restart. And monitored the stated db for memory for hours, works well: * [chassisd] Address the chassisd crash issue and add UT for it (sonic-net#573) Description On Nokia platform, slot name of Supervisor is string "A" instead of a number. Using "int" to convert it could cause issue backtrace. We should use slot value to any checking without any conversion. This will fixes sonic-net#21131 Motivation and Context Modify the _get_module_info not to convert "slot" to a string value. And also modify the code not to convert slot value to an to do any checking. Just directly use the returned value of get_slot(). Also add UT test_moduleupdater_check_slot_string() to valid it. How Has This Been Tested? Tested on 202405 branch Signed-off-by: mlok <[email protected]> * Fix a comment --------- Signed-off-by: mlok <[email protected]> Co-authored-by: Oleksandr Ivantsiv <[email protected]> Co-authored-by: Gagan Punathil Ellath <[email protected]> Co-authored-by: Ashwin Srinivasan <[email protected]> Co-authored-by: Marty Y. Lok <[email protected]> Co-authored-by: Vivek Verma <[email protected]> Co-authored-by: Patrick MacArthur <[email protected]> Co-authored-by: Peter Bailey <[email protected]> Co-authored-by: rameshraghupathy <[email protected]> Co-authored-by: Jianquan Ye <[email protected]>
tshalvi
pushed a commit
to tshalvi/sonic-buildimage
that referenced
this pull request
Aug 25, 2025
…est HEAD automatically (sonic-net#1362) #### Why I did it src/sonic-platform-common ``` * e3e1d76 - (HEAD -> 202412, origin/202412) Adding is_copper api to cmis (sonic-net#547) (sonic-net#573) (sonic-net#100) (33 hours ago) [Riff] * 1485079 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (2 days ago) [r12f] * 7c70958 - Adding is_copper api to cmis (sonic-net#547) (sonic-net#573) (13 days ago) [ravil-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…est HEAD automatically (sonic-net#1370) #### Why I did it src/sonic-platform-common ``` * 1f222d6 - (HEAD -> 202503, origin/202503) Merge pull request sonic-net#101 from mssonicbld/sonicbld/202503-merge (23 hours ago) [mssonicbld] * 28243d5 - Merge branch '202412' of https://github.com/Azure/sonic-platform-common.msft into 202503 (23 hours ago) [Sonic Automation] * e3e1d76 - (origin/202412) Adding is_copper api to cmis (sonic-net#547) (sonic-net#573) (sonic-net#100) (2 days ago) [Riff] * 1485079 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (3 days ago) [r12f] * 7c70958 - Adding is_copper api to cmis (sonic-net#547) (sonic-net#573) (2 weeks ago) [ravil-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves a number of purposes:
ENTRYPOINTsupervisorctl start, which will block until it completes. Each supervisor.conf file is configured to autostart only start.sh. All processes started using supervisorctl in start.sh are added to supervisor.conf but set to not autostart. This allows them to be started by start.sh yet be monitored by supervisord (the process must be started using supervisorctl in start.sh to be monitored).These changes were made to all dockers currently in use except docker-fpm-frr as I have no device to test on (will create an issue once this PR is merged). Other dockers not updated are deprecated and should be removed in the near future (see issue #572)