Chassisd to monitor cards in a modular chassis#5523
Chassisd to monitor cards in a modular chassis#5523jleveque merged 6 commits intosonic-net:masterfrom
Conversation
|
retest broadcom please |
|
retest please |
|
retest vsimage please |
|
retest mellanox please |
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
|
retest please |
|
retest broadcom please |
|
retest vsimage please |
|
retest mellanox please |
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
bf87113 to
49abc4f
Compare
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
49abc4f to
57a5849
Compare
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
80ba4ac to
1555c93
Compare
|
@judyjoseph please review. Was able to get a clean run after @jleveque fixed UT issues. |
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
2439356 to
c2d0b82
Compare
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
09d3d5e to
3c9ca7c
Compare
judyjoseph
left a comment
judyjoseph
left a comment
There was a problem hiding this comment.
LGTM. Will be good if we could change this variable from HAVE_MODULAR_CHASSISDB_CONF --> to a more generic one "IS_MODULAR_CHASSIS" based on this file /usr/share/sonic/platform/chassisdb.conf presence.
Done. Will need approval again. |
|
@shyam77git, @Staphylo - do you approve? |
There was a problem hiding this comment.
We are in the process of migrating all Python code from Python 2 to Python 3. I would prefer if we start with this daemon as a Python 3-only daemon, rather than having to go back in the near future and convert it. If that is not possible, then we need to build and install both Python 2 and Python 3 versions of the daemon and use the new mechanism (in PR here) to assist with the transition.
mprabhu-nokia
dismissed stale reviews from Staphylo and judyjoseph
via
6ece049
Done. Moved to python3. |
dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
Introducing chassisd process to monitor status of the control, line and fabric cards in a modular chassis.
The conf file will be present only in modular chassis SKUs
mprabhu-nokia
force-pushed
the
nokia-chassisd-pmon-1
branch
from
ffa8d5a to
4077515
Compare
6 participants
HLD: sonic-net/SONiC#646
Introducing chassisd process to monitor status of the control, line and fabric cards in a modular chassis.
- Why I did it
Modular Chassis has control-cards, line-cards and fabric-cards along with other peripherals. Chassisd will be a central entity that has visibility of the entire chassis.
- How I did it
Chassisd process will monitor cards in the main thread. Another configuation_handling_task is created to listen to CONFIG_DB for admin_status up/down events.
The monitored status is persisted in REDIS-DB.
- How to verify it
Vendor will need to implement card.py. Template APIs are provided to monitor the status of the line-card, fabric-card etc using new PMON 2.0 APIs. The assumption is that each vendor will have platform-drivers or implementation to detect the status of the cards in the chassis.