Fix generate_l2_config: don't override hostname or device role (ToRRouter)#5510
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Oct 2, 2020
Merged
Fix generate_l2_config: don't override hostname or device role (ToRRouter)#5510qiluo-msft merged 4 commits intosonic-net:masterfrom
qiluo-msft merged 4 commits intosonic-net:masterfrom
Conversation
3 tasks
…may not read from Redis. Fix test_l2switch_template test case to test preset l2 feature.
qiluo-msft
force-pushed
the
qiluo/fixl2
branch
from
1d5ffeb to
ce94696
Compare
qiluo-msft
changed the title
lguohan
approved these changes
Sep 30, 2020
Collaborator
|
retest mellanox please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…uter) (sonic-net#5510) * Fix generate_l2_config: don't override hostname because sonic-cfggen may not read from Redis. Fix test_l2switch_template test case to test preset l2 feature. * Improve test script: compare json files with sort_keys * Revert changes on sample_output * Remove members field in VLAN section. Fix test assertTrue statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonic-cfggen may not read from Redis, so override hostname will impact existing ConfigDB. Fix test_l2switch_template test case to test preset l2 feature.
- Why I did it
- How I did it
- How to verify it
Test in L2 Switch mode (https://github.com/Azure/SONiC/wiki/L2-Switch-mode)
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)