[Mellanox] Refactor SFP related platform API and plugins with new SDK API#5326
Merged
jleveque merged 2 commits intosonic-net:masterfrom Sep 11, 2020
Merged
[Mellanox] Refactor SFP related platform API and plugins with new SDK API#5326jleveque merged 2 commits intosonic-net:masterfrom
jleveque merged 2 commits intosonic-net:masterfrom
Conversation
|
This pull request fixes 4 alerts when merging a9c7575 into 679d8df - view on LGTM.com fixed alerts:
|
jleveque
approved these changes
Sep 11, 2020
Contributor
Collaborator
Author
abdosi
pushed a commit
that referenced
this pull request
Sep 29, 2020
… API (#5326) Refactor SFP reset, low power get/set API, and plugins with new SDK SX APIs. Previously they were calling SDK SXD APIs which have glibc dependency because of shared memory usage. Remove implementation "set_power_override", "tx_disable_channel", "tx_disable" which using SXD APIs, once related SDK SX API available, will add them back based on new SDK SX APIs.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
… API (sonic-net#5326) Refactor SFP reset, low power get/set API, and plugins with new SDK SX APIs. Previously they were calling SDK SXD APIs which have glibc dependency because of shared memory usage. Remove implementation "set_power_override", "tx_disable_channel", "tx_disable" which using SXD APIs, once related SDK SX API available, will add them back based on new SDK SX APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Refactor SFP reset, low power get/set API, and plugins with new SDK SX APIs. Previously they were calling SDK SXD APIs which have glibc dependency because of shared memory usage.
Remove implementation "set_power_override", "tx_disable_channel", "tx_disable" which using SXD APIs, once related SDK SX API available, will add them back based on new SDK SX APIs.
- How I did it
Refactor these API/Plugins with new set of SDK sx_mgmt_* APIs.
- How to verify it
Use sfputil command to test the plugin; load platform APIs and test changed APIs
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
[Mellanox] Refactor SFP related platform API and plugins with new SDK API
- A picture of a cute animal (not mandatory but encouraged)