Add a user defined rules/config file not tracked by git#5325
Merged
lguohan merged 1 commit intosonic-net:masterfrom Sep 10, 2020
Merged
Add a user defined rules/config file not tracked by git#5325lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
This change introduce the rules/config.user file. It gets loaded after rules/config as a mean to override default values. If the configuration file does not exists this step is ignored. Since this path is tracked by .gitignore, it provides a mean to change the configuration of sonic build without dirtying the git tree. Signed-off-by: Samuel Angebault <[email protected]>
Contributor
|
@Staphylo: Can you please add a bit more information to the description as to how the rules/config.user is used? |
Collaborator
Author
|
Thanks for the review Joe. |
yxieca
approved these changes
Sep 9, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ic-net#5325) This change introduce the rules/config.user file. It gets loaded after rules/config as a mean to override default values. If the configuration file does not exists this step is ignored. Since this path is tracked by .gitignore, it provides a mean to change the configuration of sonic build without dirtying the git tree. Signed-off-by: Samuel Angebault <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
This change introduces the
rules/config.userfile.Since this path is tracked by
.gitignore, it provides a mean to changethe configuration of a sonic build without dirtying the git tree.
- How I did it
This configuration gets loaded after
rules/configas a mean to override default values.Thus it allows the default configuration to grow with new default values without having
to track each and single one of them when one generates a configuration.
If the
rules/config.userconfiguration file does not exists this step is ignored.- How to verify it
Here is an example of the use of
rules/config.userYou should now see the new password being displayed when running a
makeoperation.Running
git statusshould not show any files in thedirtysection nor in thenot stagedsection.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Add a user defined rules/config.user file not tracked by git