[ipinip/mirror] Use asic_type instead of minigraph_hwsku#527
Closed
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
Closed
[ipinip/mirror] Use asic_type instead of minigraph_hwsku#527taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
Conversation
sihuihan88
approved these changes
Apr 21, 2017
stcheng
reviewed
Apr 22, 2017
| "src_ip":"{{ minigraph_lo_interfaces[0]['addr'] }}", | ||
| "dst_ip":"{{ minigraph_lo_interfaces[0]['addr'] }}", | ||
| {% if minigraph_hwsku in [ 'ACS-MSN2700', 'ACS-MSN2410', 'ACS-MSN2100' ] %} | ||
| {% if asic_type == 'mellanox' %} |
Contributor
There was a problem hiding this comment.
wondering if tested on any other asic types, or if we want to specify broadcom/mellanox.
Collaborator
|
can you resolve the conflict? |
Contributor
|
do we still want this? |
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 27, 2025
mssonicbld
added a commit
that referenced
this pull request
Feb 1, 2025
… automatically (#21584) #### Why I did it src/sonic-platform-common ``` * cb5564c - (HEAD -> master, origin/master, origin/HEAD) Create is_transceiver_vdm_supported API for CMIS transceivers (#527) (11 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.