[sonic-py-common] Relocate some functions from sonic-utilities#5269
Merged
judyjoseph merged 4 commits intosonic-net:masterfrom Aug 30, 2020
Merged
[sonic-py-common] Relocate some functions from sonic-utilities#5269judyjoseph merged 4 commits intosonic-net:masterfrom
judyjoseph merged 4 commits intosonic-net:masterfrom
Conversation
judyjoseph
changed the title
jleveque
previously approved these changes
Aug 28, 2020
jleveque
changed the title
jleveque
suggested changes
Aug 29, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
I recently added a unit test framework for sonic-py-common, and have begun adding unit tests there. Can you please add unit tests for these new functions?
jleveque
suggested changes
Aug 29, 2020
jleveque
approved these changes
Aug 29, 2020
Contributor
Author
|
retest this please |
abdosi
pushed a commit
that referenced
this pull request
Sep 6, 2020
* Relocate interface related common functions to py-common * Add unit tests for interface API's.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…-net#5269) * Relocate interface related common functions to py-common * Add unit tests for interface API's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the common multi-asic/general functions from sonic-utilities to py-common
validate_namespace()
get_port_table_name()
get_interface_table_name()