[radvd] No longer build from source; Install vanilla Debian package once again#5242
Merged
jleveque merged 2 commits intosonic-net:masterfrom Sep 1, 2020
jleveque:vanilla_radvd
Merged
[radvd] No longer build from source; Install vanilla Debian package once again#5242jleveque merged 2 commits intosonic-net:masterfrom jleveque:vanilla_radvd
jleveque merged 2 commits intosonic-net:masterfrom
jleveque:vanilla_radvd
Conversation
tahmed-dev
previously approved these changes
Aug 24, 2020
prsunny
reviewed
Aug 24, 2020
prsunny
approved these changes
Aug 25, 2020
Contributor
Author
|
Retest vsimage please |
1 similar comment
Contributor
Author
|
Retest vsimage please |
lguohan
approved these changes
Sep 1, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…nce again (sonic-net#5242) Remove radvd Makefile and patch, change docker-router-advertiser Dockerfile template to simply install the vanilla radvd package using apt-get. - In PR sonic-net#2795, we started building radvd from source and patching it to prevent it from erroring out when advertising an MTU of 9100 which was greater than the MTU size configured on the bridge interface (1500), which was due to a limitation in the 4.9 Linux kernel. - Master branch is now using Linux kernel 4.19. As of 4.18, the kernel supports setting a bridge MTU to a value > 1500. - PR sonic-net/sonic-swss#1393 modified vlanmgrd to take advantage of this and now configures the MTU of bridge interfaces in SONiC to the proper size of 9100. Therefore, we no longer need to patch radvd. Since we no longer need to patch radvd, we no longer need to build it from source, so we can save build time by going back to simply installing the vanilla radvd Debian package in the router-advertiser container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Resolves #3161
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)