[swss] Reduce Calls to SONiC Cfggen#5177
Merged
tahmed-dev merged 1 commit intosonic-net:masterfrom Aug 17, 2020
Merged
Conversation
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
prsunny
approved these changes
Aug 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Oct 7, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Oct 30, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Dec 4, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Dec 22, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen to one call during startup when starting swss service. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Jul 18, 2022
We have internal change of using asic_type switch.json.2. After merge of public PR sonic-net#5177 we were not passing sonic_version.yml so asic_version is not set and in 201911 code Broadcom SAI retrun errors as Not Supported for Vxlan Attribute causing orchagent to terminate. {% if "broadcom" not in asic_type %} "vxlan_port": "{{ vxlan_port }}", "vxlan_router_mac": "{{ vxlan_mac }}", {% endif %} Related work items: #3146150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting swss service.
singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- Why I did it
Reduce time required when invoking swss
- How I did it
Used template batch mode to batch together three calls into one call to sonic-cfggen
- How to verify it
- Which release branch to backport (provide reason below if selected)