Skip to content

[sonic-yang-models]: Fix vlan name pattern incorrect issue#5155

Closed
kuanyu99 wants to merge 1 commit intosonic-net:masterfrom
kuanyu99:ky_modify_sonic-yang-models
Closed

[sonic-yang-models]: Fix vlan name pattern incorrect issue#5155
kuanyu99 wants to merge 1 commit intosonic-net:masterfrom
kuanyu99:ky_modify_sonic-yang-models

Conversation

@kuanyu99
Copy link
Copy Markdown
Contributor

  • Original pattern can't accept Vlan1000~Vlan3999. Fix it.

- Why I did it

Try to fix dynamic breakout port configuration function when there is Vlan1000~Vlan3999 exist.

- How I did it

Modify the yang model pattern of the vlan name string

- How to verify it

  1. Create a vlan with name, Vlan1000
    config vlan add 1000

  2. Breakout the port
    config interface breakout Ethernet0 4x25G

  3. It should able to breakout the port

- Which release branch to backport (provide reason below if selected)

- A picture of a cute animal (not mandatory but encouraged)

* Original pattern can't accept Vlan1000~Vlan3999. Fix it.
@jleveque
Copy link
Copy Markdown
Contributor

@praveen-li: Please review.

Copy link
Copy Markdown
Member

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We fix this issue in LKDN and added new tests too, I will raise tests for review.

@praveen-li
Copy link
Copy Markdown
Member

@kuanyu99 : I raised #5165, which has the fix and the test case. If that works for you. We can commit from only PR 5165.
@jleveque

@kuanyu99
Copy link
Copy Markdown
Contributor Author

@kuanyu99 : I raised #5165, which has the fix and the test case. If that works for you. We can commit from only PR 5165.
@jleveque

Yes, it works correctly.

@jleveque
Copy link
Copy Markdown
Contributor

Closing in favor of #5165

@jleveque jleveque closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants