[sonic-yang-models]: Fix vlan name pattern incorrect issue#5155
Closed
kuanyu99 wants to merge 1 commit intosonic-net:masterfrom
Closed
[sonic-yang-models]: Fix vlan name pattern incorrect issue#5155kuanyu99 wants to merge 1 commit intosonic-net:masterfrom
kuanyu99 wants to merge 1 commit intosonic-net:masterfrom
Conversation
* Original pattern can't accept Vlan1000~Vlan3999. Fix it.
Contributor
|
@praveen-li: Please review. |
praveen-li
approved these changes
Aug 12, 2020
Member
praveen-li
left a comment
There was a problem hiding this comment.
LGTM, We fix this issue in LKDN and added new tests too, I will raise tests for review.
Member
Contributor
Author
Contributor
|
Closing in favor of #5165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Try to fix dynamic breakout port configuration function when there is Vlan1000~Vlan3999 exist.
- How I did it
Modify the yang model pattern of the vlan name string
- How to verify it
Create a vlan with name, Vlan1000
config vlan add 1000Breakout the port
config interface breakout Ethernet0 4x25GIt should able to breakout the port
- Which release branch to backport (provide reason below if selected)
- A picture of a cute animal (not mandatory but encouraged)