[201911][Python] Migrate applications/scripts to import sonic-py-common package#5132
Merged
jleveque merged 6 commits intosonic-net:201911from Aug 13, 2020
jleveque:use_sonic_py_common_201911
Merged
[201911][Python] Migrate applications/scripts to import sonic-py-common package#5132jleveque merged 6 commits intosonic-net:201911from jleveque:use_sonic_py_common_201911
jleveque merged 6 commits intosonic-net:201911from
jleveque:use_sonic_py_common_201911
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request fixes 4 alerts when merging 9d8d8e4 into 13386c1 - view on LGTM.com fixed alerts:
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request:
sonic_device_util.get_platform_info()to instead callsonic_py_common.get_platform()and removes any calls tosonic_device_util.get_machine_info()which are no longer necessary (i.e., those which were only used to pass the results tosonic_device_util.get_platform_info().This is a step toward resolving #4999
- How to verify it
Test that all affected Python applications/scripts continue to function properly in 201911