Skip to content

[device/celestica]: Implement Seastone2 platform API#5080

Merged
jleveque merged 37 commits intosonic-net:masterfrom
mudsut4ke:master_seastone2_api
Sep 9, 2020
Merged

[device/celestica]: Implement Seastone2 platform API#5080
jleveque merged 37 commits intosonic-net:masterfrom
mudsut4ke:master_seastone2_api

Conversation

@mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Jul 31, 2020

- What I did

  • Implement Seastone2 platform API

- How I did it

  1. Implement Fan APIs.
  2. Implement Psu APIs.
  3. Implement Thermal APIs.
  4. Implement Component APIs.
  5. Implement Chassis APIs.
  6. Implement Sfp APIs.
  7. Implement Watchdog APIs. (Required new CPLD version)
  8. Upgrade switchboard driver to support port insert/remove interrupt
  9. Init all above APIs class on chassis API.

- How to verify it

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

Wirut Getbamrung and others added 26 commits June 26, 2020 17:07
Initialize get_status_led function for fan led.
[device/celestica-silverstone2]: Implement ThermalBase API
Dev seastone2 api on sfp function.
@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 31 alerts when merging 9392c1d into d24d717 - view on LGTM.com

new alerts:

  • 11 for Unused local variable
  • 8 for Unused import
  • 7 for Except block handles 'BaseException'
  • 2 for Unreachable code
  • 1 for Module imports itself
  • 1 for Implicit string concatenation in a list
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 31 alerts when merging 3a2cc6d into 81e0777 - view on LGTM.com

new alerts:

  • 11 for Unused local variable
  • 8 for Unused import
  • 7 for Except block handles 'BaseException'
  • 2 for Unreachable code
  • 1 for Module imports itself
  • 1 for Implicit string concatenation in a list
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 7 alerts when merging 9e183e6 into fe38728 - view on LGTM.com

new alerts:

  • 7 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 7 alerts when merging 8e86f6e into fe38728 - view on LGTM.com

new alerts:

  • 7 for Except block handles 'BaseException'

@mudsut4ke
Copy link
Contributor Author

retest broadcom please

@mudsut4ke mudsut4ke marked this pull request as ready for review August 4, 2020 05:00
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix remaining LGTM alerts (catch Exception rather than BaseException)

@lgtm-com
Copy link

lgtm-com bot commented Aug 14, 2020

This pull request introduces 1 alert when merging 634f845 into bf3c901 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2020

This pull request introduces 7 alerts when merging 243f9ea into d370ba7 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 3 for Unused local variable

@mudsut4ke
Copy link
Contributor Author

@jleveque , Can you merge this PR ?

@jleveque jleveque merged commit aa601f4 into sonic-net:master Sep 9, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Implement Seastone2 platform API:

1. Implement Fan APIs.
2. Implement Psu APIs.
3. Implement Thermal APIs.
4. Implement Component APIs.
5. Implement Chassis APIs.
6. Implement Sfp APIs.
7. Implement Watchdog APIs. (Required new CPLD version)
8. Upgrade switchboard driver to support port insert/remove interrupt
9. Init all above APIs class on chassis API.

Co-authored-by: pjaipakdee <jai.peerapong@gmail.com>
Co-authored-by: Pradchaya P <pphuchar@celestica.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants