[bgpcfgd]: Clarify error messages on reset Loopback0 ip address#5062
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 30, 2020
Merged
[bgpcfgd]: Clarify error messages on reset Loopback0 ip address#5062lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
retest vs please |
Contributor
Author
|
retest vs please |
lguohan
approved these changes
Jul 30, 2020
abdosi
pushed a commit
that referenced
this pull request
Aug 9, 2020
To clarify error messages in case the ip address for Loopback is already set. It doesn't make sense to call correct ip address as ambiguous in this case
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…c-net#5062) To clarify error messages in case the ip address for Loopback is already set. It doesn't make sense to call correct ip address as ambiguous in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
To clarify error messages in case the ip address for Loopback is already set. It doesn't make sense to call correct ip address as ambiguous in this case
- How I did it
I split the check of constraints into two if clauses. One to check if the ip is correct or not. The second one to check if the ip address was already registered or not.
- How to verify it
- Which release branch to backport (provide reason below if seleted)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)