[Mellanox] Update the buffer setting#4989
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Jul 30, 2020
Merged
Conversation
Collaborator
Author
|
retest this please |
keboliu
previously approved these changes
Jul 20, 2020
Collaborator
|
retest this please |
Collaborator
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
Please extend your PR message with more information about motivation, which SKUs are affected and how to have this new values enforced. Add relation to the db migrator PR as well
Collaborator
Author
Done. |
Collaborator
Author
|
retest this please |
added 2 commits
July 29, 2020 15:32
Signed-off-by: Stephen Sun <stephens@mellanox.com>
- reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <stephens@mellanox.com>
stephenxs
force-pushed
the
new-buffer-setting
branch
from
b921477 to
2dfe83e
Compare
3 tasks
liat-grozovik
approved these changes
Jul 30, 2020
Collaborator
|
This PR was tested by QoS community test and all is passing for the different ASICs/platforms. |
abdosi
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Update the buffer size based on the latest excel Signed-off-by: Stephen Sun <stephens@mellanox.com> * Align the buffer configuration with the latest formula: - reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <stephens@mellanox.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* Update the buffer size based on the latest excel Signed-off-by: Stephen Sun <stephens@mellanox.com> * Align the buffer configuration with the latest formula: - reduce redundant "*2" in formula - use port MTU for local sending the PFC frame and peer lossless MTU for peer sending lossless traffic Buffer pool size updated accordingly. Signed-off-by: Stephen Sun <stephens@mellanox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the buffer size.
Signed-off-by: Stephen Sun stephens@mellanox.com
- Why I did it
Recently buffer configuration has been updated:
dynamic_thof profiles used for BUFFER_PORT_INGRESS_PROFILE_LIST/BUFFER_PORT_EGRESS_PROFILE_LIST which represent per port ingress/egress reserved buffer respectively.This update is applied to all Mellanox platforms and SKUs. It is enforced by the
db_migratorwhich will check the buffer configuration after a switch undergoes a SONiC-to-SONiC upgrade from an old image to a new one. If the buffer configuration matches the default value it will be upgraded to the new one. The granularity of matching is:It depends on sonic-utilities PR #993 which includes the
db_migratorpart.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)