Conversation
|
This pull request introduces 3 alerts when merging dd35bfb into de16e6f - view on LGTM.com new alerts:
|
|
[LGTM] : I suppress the 3 import * warning. Reference: #4677. |
|
retest mellanox please |
|
retest vsimage please |
|
@jleveque Please help review. Thanks! |
platform/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/__init__.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/fan.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/sfp.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
...m/broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/thermal_infos.py
Outdated
Show resolved
Hide resolved
|
This pull request introduces 3 alerts when merging 1ec2fc8 into 18bfa6d - view on LGTM.com new alerts:
|
|
retest vsimage please |
device/alphanetworks/x86_64-alphanetworks_snj60b0_320f-r0/fancontrol
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2068 @@ | |||
| /* | |||
| * SFP driver for alphanetworks snj60b0-320f sfp | |||
There was a problem hiding this comment.
Please use existing optoe driver in lieu of creating a custom driver.
There was a problem hiding this comment.
Because of HW design, we use a custom driver.
There was a problem hiding this comment.
Can you explain why your HW design does not work with the optoe driver? As long as your HW conforms to the standard specs, it should be able to access the EEPROM fine.
There was a problem hiding this comment.
Why we need proprietary EEPROM driver is because we use “CPLD” instead of I/O port expansion in our HW design. Therefore we need to control CPLD first, then we could access EEPROM. (The CPLD will also have functionality other than EEPROM access.)
It is our HW design for saving cost and space.
|
This pull request introduces 3 alerts when merging 800c17a into 458b4ae - view on LGTM.com new alerts:
|
|
@jleveque Please help review. Thanks! |
|
@lguohan Please help review. Thanks! |
|
@jleveque Could you merge this pull request? |
|
@lguohan to review, also. |
|
@lguohan Please help review. Thanks! |
2 similar comments
|
@lguohan Please help review. Thanks! |
|
@lguohan Please help review. Thanks! |
|
@jleveque Could you merge this pull request? |
...broadcom/sonic-platform-modules-alphanetworks/snj60b0-320f/sonic_platform/thermal_manager.py
Show resolved
Hide resolved
|
@jleveque Could you merge this pull request? |
|
@jleveque Could you merge this pull request? |
2 similar comments
|
@jleveque Could you merge this pull request? |
|
@jleveque Could you merge this pull request? |
jleveque
changed the title
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
As comments. Also, please note that SONiC is transitioning from Python 2 to Python 3. Please ensure you are building and installing both Python 2 and Python 3 versions of your sonic_platfomr package. Once the transition is complete, you will be able to stop building the Python 2 package.
| @@ -0,0 +1,14 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,219 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,79 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,224 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,22 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,925 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
| @@ -0,0 +1,176 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shebang not necessary here, as the script is not executable. Please remove.
2 participants
- What I did it
Add new platform x86_64-alphanetworks_snj60b0-320f (Tomahawk3)
ASIC Vendor: Broadcom
Switch ASIC: Tomahawk3
Port Config: 32x400G
- How I did it
Provide device and platform related files.
- How to verify it
show platform fan
show platform ssdhealth
show platform psustatus
show platform summary
show platform syseeprom
show platform temperature
show interface status
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)