[swss] Call sonic-cfggen Once#4936
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 14, 2020
Merged
Conversation
tahmed-dev
commented
Jul 9, 2020
qiluo-msft
reviewed
Jul 9, 2020
Collaborator
There was a problem hiding this comment.
export [](start = 0, length = 6)
export [](start = 0, length = 6)
If removing export, is it the same? #Closed
Contributor
Author
There was a problem hiding this comment.
should be, not sure why the original script had export!
tahmed-dev
force-pushed
the
taahme/swss-calls-sonic-cfggen-once
branch
from
02fafdf to
9897a76
Compare
Optimizing number of calls made to sonic-cfggen during service start up as it adds to total system boot up time. signed-off-by: Tamer Ahmed <[email protected]>
tahmed-dev
force-pushed
the
taahme/swss-calls-sonic-cfggen-once
branch
from
9897a76 to
0b525b7
Compare
pavel-shirshov
approved these changes
Jul 14, 2020
qiluo-msft
approved these changes
Jul 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Jul 26, 2020
Optimizing number of calls made to sonic-cfggen during service start up as it adds to total system boot up time. signed-off-by: Tamer Ahmed <[email protected]> **- Why I did it** sonic-cfggen call is slow and it adds to system start up time **- How I did it** places all required variable into single template and called into sonic-cfggen using this template **- How to verify it** ***-Test 1*** there is an average saving of .5 to 1 sec between old script and new script ``` root@str-s6000-acs-14:/# time ./orchagent_old.sh /usr/bin/orchagent -d /var/log/swss -b 8192 -m f4:8e:38:16:bc:8d real 0m3.546s user 0m2.365s sys 0m0.585s root@str-s6000-acs-14:/# time ./orchagent_new.sh /usr/bin/orchagent -d /var/log/swss -b 8192 -m f4:8e:38:16:bc:8d real 0m2.058s user 0m1.650s sys 0m0.363s ``` ***-Test 2*** Built an image with this change and orchagent is running with intended params: ``` admin@str-s6000-acs-14:~$ ps -ef | grep orchagent root 2988 1901 1 02:09 pts/0 00:00:02 /usr/bin/orchagent -d /var/log/swss -b 8192 -m f4:8e:38:16:bc:8d ``` signed-off-by: Tamer Ahmed <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizing number of calls made to sonic-cfggen during service
start up as it adds to total system boot up time.
signed-off-by: Tamer Ahmed [email protected]
- Why I did it
sonic-cfggen call is slow and it adds to system start up time
- How I did it
places all required variable into single template and called into sonic-cfggen using this template
- How to verify it
-Test 1
there is an average saving of .5 to 1 sec between old script and new script
-Test 2
Built an image with this change and orchagent is running with intended params:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)