[sonic-buildimage] Changes to make network specific sysctl common for both host and docker namespace#4838
Merged
abdosi merged 3 commits intosonic-net:masterfrom Jul 1, 2020
Merged
Conversation
common for both host and docker namespace (in multi-npu). This change is triggered with issue found in multi-npu platforms where in docker namespace net.ipv6.conf.all.forwarding was 0 (should be 1) because of which RS/RA message were triggered and link-local router were learnt. Beside this there were some other sysctl.net.ipv6* params whose value in docker namespace is not same as host namespace. So to make we are always in sync in host and docker namespace created common file that list all sysctl.net.* params and used both by host and docker namespace. Any change will get applied to both namespace. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Contributor
|
Thanks. Could we please use multi-asic term consistently and not use multi-npu term any more (so that code is also consistent)? @rlhui this PR does not reference this term in code. Updated in PR description from multi-npu to multi-asic |
Contributor
Author
|
retest vsimage please |
Contributor
Author
prsunny
reviewed
Jun 26, 2020
jleveque
suggested changes
Jun 27, 2020
only one and do string concatenation of all set commands
Contributor
Author
Contributor
Author
|
retest vsimage please |
prsunny
previously approved these changes
Jun 30, 2020
Contributor
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
lgtm, wait for other reviewers.
yxieca
previously approved these changes
Jun 30, 2020
Contributor
Author
|
can you please review/approve this. |
jleveque
reviewed
Jul 1, 2020
jleveque
approved these changes
Jul 1, 2020
abdosi
added a commit
that referenced
this pull request
Jul 5, 2020
… both host and docker namespace (#4838) * [sonic-buildimage] Changes to make network specific sysctl common for both host and docker namespace (in multi-npu). This change is triggered with issue found in multi-npu platforms where in docker namespace net.ipv6.conf.all.forwarding was 0 (should be 1) because of which RS/RA message were triggered and link-local router were learnt. Beside this there were some other sysctl.net.ipv6* params whose value in docker namespace is not same as host namespace. So to make we are always in sync in host and docker namespace created common file that list all sysctl.net.* params and used both by host and docker namespace. Any change will get applied to both namespace. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Address Review Comments and made sure to invoke augtool only one and do string concatenation of all set commands * Address Review Comments.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 12, 2020
… both host and docker namespace (sonic-net#4838) * [sonic-buildimage] Changes to make network specific sysctl common for both host and docker namespace (in multi-npu). This change is triggered with issue found in multi-npu platforms where in docker namespace net.ipv6.conf.all.forwarding was 0 (should be 1) because of which RS/RA message were triggered and link-local router were learnt. Beside this there were some other sysctl.net.ipv6* params whose value in docker namespace is not same as host namespace. So to make we are always in sync in host and docker namespace created common file that list all sysctl.net.* params and used both by host and docker namespace. Any change will get applied to both namespace. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Address Review Comments and made sure to invoke augtool only one and do string concatenation of all set commands * Address Review Comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Changes to make network specific sysctl common for both host and docker namespace (in multi-asic).
This change is triggered with issue found in multi-npu platforms
where in docker namespace
net.ipv6.conf.all.forwarding was 0 (should be 1) because of
which IPv6 RS/RA message were triggered and routes on link-local address were learnt.
Beside this there were some other sysctl.net.ipv6* params whose value
in docker namespace is not same as host namespace.
- How I did it
So to make we are always in sync in host and docker namespace
created common file that list all sysctl.net.* params and used
both by host and docker namespace. Any change will get applied
to both namespace.
The new files is used only in docker namespace using command "sysctl --system -e"
For Host namespace current mechanism of set -f will be used via reading this file.
- How to verify it
Verified both Single and Multi-Asic sysctl.net.* params are applied correctly.
Also IPv6 RS/RA message are not triggered and routes were learnt on global address.