Skip to content

[Mellanox] Add support for set/get system led status#4829

Merged
jleveque merged 3 commits intosonic-net:masterfrom
Junchao-Mellanox:system-led-api
Jul 13, 2020
Merged

[Mellanox] Add support for set/get system led status#4829
jleveque merged 3 commits intosonic-net:masterfrom
Junchao-Mellanox:system-led-api

Conversation

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator

- Why I did it

System health feature needs to set/get system led status

- How I did it

  1. Add a led object in chassis class and initialize it when the API is called on host side
  2. Read/write system led system fs to get/set the status

- How to verify it

Manual test on SN2700

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator Author

Retest vsimage please

@sujinmkang
Copy link
Copy Markdown
Collaborator

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator Author

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

No, we cannot for now because driver doesn't put the LED status to that file as I tested.

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator Author

Retest vsimage please.

@keboliu
Copy link
Copy Markdown
Collaborator

keboliu commented Jul 7, 2020

retest vsimage please

@keboliu keboliu requested a review from jleveque July 13, 2020 09:59
@jleveque jleveque merged commit 76d68ad into sonic-net:master Jul 13, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the system-led-api branch September 18, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants