Skip to content

added files to create SKU Mellanox-SN3800-D24C52#4808

Merged
prsunny merged 2 commits intosonic-net:masterfrom
madhanmellanox:madhanskucreate_D24C52
Jun 21, 2020
Merged

added files to create SKU Mellanox-SN3800-D24C52#4808
prsunny merged 2 commits intosonic-net:masterfrom
madhanmellanox:madhanskucreate_D24C52

Conversation

@madhanmellanox
Copy link
Contributor

What I did
Added all the relevant files to create SKU Mellanox-SN3800-D24C52

How I did it
Created all the SKU related files using a XML file provided and a sonic_sku_create.py script to generate the files.

How to verify it
Load the new HWKU related config using follow command and reload the config.
sudo sonic-cfggen --preset l2 -p -H -k Mellanox-SN3800-D24C52 > /tmp/newconfig
sudo cp /tmp/newconfig /etc/sonic/config_db.json
sudo config reload
show interfaces status

Description for the changelog
Added SKU related files buffers_defaults_t0.j2, buffers_defaults_t1.j2, buffers.json.j2, pg_profile_lookup.ini, port_config.ini, qos.json.j2, sai_3800.xml and sai.profile.

- A picture of a cute animal (not mandatory but encouraged)

@@ -0,0 +1 @@
SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/sai_3800.xml
Copy link
Contributor

@prsunny prsunny Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly keep the name as sai_3800_24x50g_52x100g as that's a convention followed for other SKU's as well. You can check this . It can be used to identify the file in syncd docker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the next commit

@@ -0,0 +1,77 @@
# name lanes alias index speed
Copy link
Collaborator

@nazariig nazariig Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhanmellanox please use the same alignment as in this PR: #4085

Copy link
Collaborator

@nazariig nazariig Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhanmellanox do we need fec for this SKU?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SKU is generated by sonic_sku_create.py and it is using tabulate method of tabulate module, that is the reason for the alignment.
FEC is not present in the 2700 SKUs. So, FEC is not mandatory.

<device-mac-address>00:02:03:04:05:00</device-mac-address>

<!-- ISSU enabled -->
<issu-enabled>1</issu-enabled>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhanmellanox please fix alignment. Also make sure spaces (not tabs) are used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sai_3800_24x50g_52x100g.xml is a copy of ../ACS-3800/sai_3800.xml

@prsunny prsunny merged commit b5f1b37 into sonic-net:master Jun 21, 2020
abdosi pushed a commit that referenced this pull request Jun 28, 2020
* added files to create SKU Mellanox-SN3800-D24C52

Co-authored-by: Madhan Babu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants