Skip to content

[interfaces]: Do not bring up LAG members when LAG is not up #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stcheng merged 1 commit into from
Apr 5, 2017
Merged

[interfaces]: Do not bring up LAG members when LAG is not up #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion files/image_config/interfaces/interfaces.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ auto {{ member }}
allow-hotplug {{ member }}
iface {{ member }} inet manual
pre-up teamdctl {{ pc }} port add {{ member }} || true
post-up ifconfig {{ member }} up
post-up ip link show {{ pc }} && ifconfig {{ member }} up
Copy link
Collaborator

@lguohan lguohan Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you said that teamdctl port add will add the member while bring up the member, then why post-up is neccessary?

Copy link
Contributor Author

@stcheng stcheng Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we do ifdown/ifup after the interfaces become part of the LAG, we will need this.

post-down ifconfig {{ member }} down
#
{% endfor %}
Expand Down