[rules/sonic-utilities.mk] Add sonic-yang-mgmt as build time dependency#4798
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jun 19, 2020
Merged
Conversation
…ncy for sonic-utilities. To run the unit test for sonic-utilities/config/config_mgmt.py, we need sonic-yang-mgmt. It is decided to not mock sonic-yang-mgmt because config_mgmt is highly dependent on sonic-yang-mgmt. So It is good to catch any compatibility issues during build time rather than run time. Signed-off-by: Praveen Chaudhary [email protected]
Member
Author
|
Hi Joe, Will it be possible for you to merge this PR. I need it to run test cases for PR 765. As discussed my test depend on sonic_yang. Thx. |
jleveque
changed the title
jleveque
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To run the unit test for sonic-utilities/config/config_mgmt.py, we need sonic-yang-mgmt.
It is decided to not mock sonic-yang-mgmt because config_mgmt is highly dependent on sonic-yang-mgmt.
So It is good to catch any compatibility issues during build time rather than run time.
Signed-off-by: Praveen Chaudhary [email protected]
- Why I did it
Add sonic-yang-mgmt as build time dependency for sonic-utilities.
- How I did it
Change wheel_depends in rules/sonic-utilities.mk.
- How to verify it
Test Will Run after merging:
sonic-net/sonic-utilities#765
sonic-net/sonic-utilities#947
Results are in sonic-net/sonic-utilities#947
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)