Convert radv docker to buster#4727
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jun 12, 2020
Merged
Conversation
Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
Contributor
Author
|
retest vsimage please |
jleveque
suggested changes
Jun 9, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
In the rules/radvd.mk Makefile, the version is set to 2.17-2~bpo9+1, as we were building the version which was backported to Stretch. Since we are now building on Buster, this version should be changed to the latest version available for Buster, 2.17-2 (i.e., not the Stretch backport version). Can you please change this and ensure it builds properly?
Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
Contributor
Author
|
It builds fine. I see radvd_2.17-2_amd64.deb created. |
jleveque
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
This is an enhancement.
- How I did it
Code changes
- How to verify it
Build radv docker using
BLDENV=buster make -f Makefile.work target/docker-router-advertiser.gzCheck that /etc/apt/sources.list in radv docker references buster.
- Description for the changelog
Changes to convert radv (router-advertiser) docker to buster
Signed-off-by: Joyas Joseph joyas_joseph@dell.com
- A picture of a cute animal (not mandatory but encouraged)