[hostcfgd] Synchronize all feature statuses once upon start#4714
Merged
jleveque merged 3 commits intosonic-net:masterfrom Jun 20, 2020
jleveque:hostcfgd_update_feature_at_start
Merged
[hostcfgd] Synchronize all feature statuses once upon start#4714jleveque merged 3 commits intosonic-net:masterfrom jleveque:hostcfgd_update_feature_at_start
jleveque merged 3 commits intosonic-net:masterfrom
jleveque:hostcfgd_update_feature_at_start
Conversation
jleveque
changed the title
prsunny
previously approved these changes
Jun 20, 2020
| continue | ||
| feature_name = key | ||
| feature_table = self.config_db.get_table('FEATURE') | ||
| if feature_name not in feature_table.keys(): |
Contributor
There was a problem hiding this comment.
Just curious, is it possible to delete a feature from feature_table after it is enabled?
Contributor
Author
There was a problem hiding this comment.
No. The concept is that "features" are built into the image. They cannot be removed, only disabled.
prsunny
approved these changes
Jun 20, 2020
abdosi
pushed a commit
that referenced
this pull request
Jun 28, 2020
- Ensure all features (services) are in the configured state when hostcfgd starts - Better functionalization of code - Also replace calls to deprecated `has_key()` method in `tacacs_server_handler()` and `tacacs_global_handler()` with `in` keyword. This PR depends on sonic-net/sonic-utilities#944, otherwise `config load_minigraph` will fail when trying to restart disabled services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_key()method intacacs_server_handler()andtacacs_global_handler()withinkeyword.This PR depends on sonic-net/sonic-utilities#944, otherwise
config load_minigraphwill fail when trying to restart disabled services.