Skip to content

[docker-sonic-mgmt]: Include patch to support 'become' and 'become_user' arguments in pytest-ansible#4681

Merged
lguohan merged 3 commits intosonic-net:masterfrom
ArunSaravananBalachandran:pytest_become_patch
Jun 12, 2020
Merged

[docker-sonic-mgmt]: Include patch to support 'become' and 'become_user' arguments in pytest-ansible#4681
lguohan merged 3 commits intosonic-net:masterfrom
ArunSaravananBalachandran:pytest_become_patch

Conversation

@ArunSaravananBalachandran
Copy link
Contributor

- Why I did it

  • To support 'become' and 'become_user' arguments in pytest-ansible in 'docker-sonic-mgmt'

Required by sonic-mgmt/PR1702 : [pytest] Convert interface naming mode test to pytest

- How I did it

Apply pytest-ansible/PR46 patch to pytest-ansible while building 'docker-sonic-mgmt'.

- How to verify it

Use 'become', 'become_user' arguments in pytest script to login as a different user into host device.

- Description for the changelog

[docker-sonic-mgmt]: Include patch to support 'become' and 'become_user' arguments in pytest-ansible

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jun 1, 2020

retest baseimage please

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grab the source and use python setup.py to build and install

@ArunSaravananBalachandran
Copy link
Contributor Author

ArunSaravananBalachandran commented Jun 2, 2020

grab the source and use python setup.py to build and install

@lguohan , as suggested made changes to build pytest-ansible from source using setup.py.
Install of latest ansible (2.9.9) was failing, which was initiated automatically by easy_install since it is a dependency of pytest-ansible.
So, the installation of pytest-ansible is performed after ansible has been installed to avoid the failure.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check out a specific version.

@lguohan
Copy link
Collaborator

lguohan commented Jun 9, 2020

grab the source and use python setup.py to build and install

@lguohan , as suggested made changes to build pytest-ansible from source using setup.py.
Install of latest ansible (2.9.9) was failing, which was initiated automatically by easy_install since it is a dependency of pytest-ansible.
So, the installation of pytest-ansible is performed after ansible has been installed to avoid the failure.

I am ok with this change.

@lguohan lguohan merged commit a748dae into sonic-net:master Jun 12, 2020
rlhui pushed a commit that referenced this pull request Jul 7, 2020
@ArunSaravananBalachandran ArunSaravananBalachandran deleted the pytest_become_patch branch July 17, 2020 06:00
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants