[build] 'make reset' target will continue recursive operations even if some fail

[jleveque]

This change allows the recursive git clean and git reset commands to continue even if they encounter an error in one of the submodules. Previously, if an error was encountered, the operation would terminate with a message similar to the following:

Stopping at 'src/sonic-mgmt-framework'; script returned non-zero status.

[jleveque]

Retest vs please

[lguohan]

when would the command fail on the mgmt-framework submodule?

[lguohan]

retest vs please

[jleveque]

@lguohan: It fails to delete files in the gopkgs subdirectory. This permissions issue needs further investigation. Some example messages:

...
warning: failed to remove gopkgs/pkg/mod/github.com/golang/[email protected]/proto/map_test.go: Permission denied
warning: failed to remove gopkgs/pkg/mod/github.com/golang/[email protected]/proto/properties.go: Permission denied
warning: failed to remove gopkgs/pkg/mod/github.com/golang/[email protected]/ptypes/duration_test.go: Permission denied
warning: failed to remove gopkgs/pkg/mod/github.com/golang/[email protected]/ptypes/timestamp/timestamp.pb.go: Permission denied
...

[jleveque]

Retest vsimage please

[lguohan]

retest vsimage please

[lguohan]

why in this case, we should skip these errors and let it continue? shouldn't we ask broadcom to fix the reset issue on their repo?

[jleveque]

@lguohan: Yes, Broadcom should fix the root cause, but this patch allows the command to continue and reset the remaining submodules. The error messages still get printed to stdout, so it will be noticed, it's not suppressed. This patch just prevents the need to manually clean up multiple submodules if any one fails to clean up.

[lguohan]

retest vsimage please

[lguohan]

when you merge, can you make sure you edited the commit message to include what you have in the pr.