DellEMC: get_change_event Platform API implementation for S6000, S6100 and Z9100#4593
Merged
lguohan merged 2 commits intosonic-net:masterfrom May 20, 2020
Merged
Conversation
Contributor
Author
|
This PR needs to be picked for 201911 branch. |
|
This pull request introduces 2 alerts and fixes 1 when merging 5e9c885 into 0542afb - view on LGTM.com new alerts:
fixed alerts:
|
Collaborator
|
@ArunSaravananBalachandran Can you please fix the LGTM alerts? |
|
This pull request fixes 3 alerts when merging a7cc834 into af95d57 - view on LGTM.com fixed alerts:
|
Contributor
Author
@sujinmkang Resolved the LGTM alerts. |
jleveque
approved these changes
May 19, 2020
Contributor
|
Retest mellanox please |
abdosi
pushed a commit
that referenced
this pull request
May 28, 2020
…0 and Z9100 (#4593) For detecting transceiver change events through xcvrd in DellEMC S6000, S6100 and Z9100 platforms. - In S6000, rename 'get_transceiver_change_event' in chassis.py to 'get_change_event' and return appropriate values. - In S6100, implement 'get_change_event' through polling method (poll interval = 1 second) in chassis.py (Transceiver insertion/removal does not generate interrupts due to a CPLD bug) - In Z9100, implement 'get_change_event' through interrupt method using select.epoll().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
For detecting transceiver change events through xcvrd in DellEMC S6000, S6100 and Z9100 platforms.
- How I did it
- How to verify it
Perform transceiver insertion/removal and check the transceiver presence using "show interfaces transceiver command". During transceiver insertion/removal testing, no substantial CPU spike was observed when pfcwd was enabled.
UT Logs:
S6000_OIR_UT_logs.txt
S6100_OIR_UT_logs.txt
Z9100_OIR_UT_logs.txt
- Description for the changelog
DellEMC: get_change_event Platform API implementation for S6000, S6100 and Z9100
- A picture of a cute animal (not mandatory but encouraged)