Skip to content

[201911][sonic-telemetry] Point submodule to head of 201911 branch#4493

Closed
jleveque wants to merge 1 commit intosonic-net:201911from
jleveque:update_telemetry_201911
Closed

[201911][sonic-telemetry] Point submodule to head of 201911 branch#4493
jleveque wants to merge 1 commit intosonic-net:201911from
jleveque:update_telemetry_201911

Conversation

@jleveque
Copy link
Contributor

@jleveque jleveque commented Apr 28, 2020

Update sonic-telemetry submodule pointer in sonic- buildimage 201911 branch to point to 201911 branch of submodule (sonic-telemetry).

This effectively rolls the following commit out of the 201911 branch:
• aaa9188fda4b6f36dd5da00cdb240933fedae5ce: SONiC Management Framework Release 1.0 (#23)

@pra-moh
Copy link
Contributor

pra-moh commented Apr 28, 2020

Just FYI, I updated PR description to correct commit.

@jleveque
Copy link
Contributor Author

jleveque commented Apr 28, 2020

@pra-moh: I believe the commit I had in the description originally was correct. I was listing the commit which I effectively rolled out by updating this submodule. You changed it to be the new head.

@pra-moh
Copy link
Contributor

pra-moh commented Apr 28, 2020

@pra-moh: I believe the commit I had in the description originally was correct. I was listing the commit which I effectively rolled out by updating this submodule. You changed it to be the new head.

Oh Ok. My bad. I thought you wanted to show commit to which it will point. Let me revert back

@jleveque
Copy link
Contributor Author

Retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Apr 29, 2020

what is the problem of master? is the function broken?

@jleveque
Copy link
Contributor Author

jleveque commented May 4, 2020

@pra-moh, @hui-ma: Can you answer Guohan's question? I understand you want to roll the SONiC Manangent Framework changes out of the 20911 branch. Can you explain why?

@jleveque
Copy link
Contributor Author

jleveque commented May 6, 2020

Abandoning this pull request. There is no need to create a 201911 branch of sonic-telemetry at this point in time.

@jleveque jleveque closed this May 6, 2020
@jleveque jleveque deleted the update_telemetry_201911 branch May 6, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants