bgp template changes for new multi Asic minigraph#4488
Merged
lguohan merged 3 commits intosonic-net:masterfrom May 6, 2020
Merged
bgp template changes for new multi Asic minigraph#4488lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
pavel-shirshov
previously approved these changes
May 1, 2020
Contributor
pavel-shirshov
left a comment
pavel-shirshov
left a comment
There was a problem hiding this comment.
looks good for me
Contributor
|
We should wait until we have 'sub-role' generation merged to the master? |
Contributor
Author
|
retest vsimage please |
Contributor
|
you need to rebase the new parser to this change first |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
arlakshm
force-pushed
the
multi_asic_bgp_template_chanegs
branch
from
0db9ce2 to
4a2c124
Compare
Contributor
Author
|
retest vsimage please |
pavel-shirshov
approved these changes
May 6, 2020
abdosi
pushed a commit
that referenced
this pull request
May 7, 2020
…orms (#4488) - change the references to 'type' field to 'sub_role' - change the references to 'InternalFrontend' and 'InternalBackend' to 'FrontEnd' and 'BackEnd' respectively - add a statement to reflect route-reflector for backend asics - add a change to set "next-hop-self force" configuration for internal BGP session in multi asic platform. Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
- Why I did it
Align the bgp templates with new minigraph generated for multi NPU platforms
- How I did it
change the references to 'type' field to 'sub_role'
change the references to 'InternalFrontend' and 'InternalBackend' to 'FrontEnd' and 'BackEnd' respectively
- How to verify it
Check if the configuration is generated properly on multi NPU platforms
- Description for the changelog
change the references to 'type' field to 'sub_role'
change the references to 'InternalFrontend' and 'InternalBackend' to 'FrontEnd' and 'BackEnd' respectively
add a statement to reflect route-reflector for backend asics
Add a change to set "next-hop-self force" configuration for internal BGP session in multi asic platform.
- A picture of a cute animal (not mandatory but encouraged)