Create docker-base-buster and docker-config-engine-buster#4480
Merged
lguohan merged 3 commits intosonic-net:masterfrom Apr 28, 2020
Merged
Create docker-base-buster and docker-config-engine-buster#4480lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
This change adds support to build dockers using buster as base. 1) Define docker-base-buster using docker-base-stretch as starting point 2) Define docker-config-engine-buster using docker-config-engine-stretch as starting point. sonic-mgmt-framework docker is updated to build using buster as base Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
lguohan
reviewed
Apr 24, 2020
lguohan
reviewed
Apr 24, 2020
lguohan
reviewed
Apr 24, 2020
lguohan
reviewed
Apr 24, 2020
lguohan
reviewed
Apr 24, 2020
lguohan
reviewed
Apr 24, 2020
Collaborator
|
what kind of validation have you done since you have switch mgmt-framework to buster docker, have you validated if the mgmt-framework running successful in buster? |
Collaborator
|
btw, can you follow the pr template to fill answers for those questions. |
Contributor
Author
I have loaded the image on an S6000 switch and verified that commands work. I have also verified that libjemalloc2 is the package installed in the docker. |
1. Remove SONIC_STRETCH_DOCKERS The dockers in SONIC_DOCKER_IMAGES but not in SONIC_STRETCH_DOCKERS are to be built for buster Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
lguohan
reviewed
Apr 26, 2020
- DOCKER_IMAGES is derived by filtering out SONIC_JESSIE_DOCKERS and SONIC_STRETCH_DOCKERS from SONIC_DOCKER_IMAGES Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
lguohan
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
This change adds support to build dockers using buster as base.
- How I did it
as starting point.
sonic-mgmt-framework docker is updated to build using buster as base
- How to verify it
During build:
Check that target/docker-base-buster.gz, target/docker-config-engine-buster.gz are being built
Check that the dependencies for sonic-mgmt-framework are being built in target/debs/buster directory
Runtime:
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Joyas Joseph joyas_joseph@dell.com