Fix the continous syseepromd autorestart issue on 201911#4478
Merged
lguohan merged 2 commits intosonic-net:masterfrom Apr 30, 2020
sujinmkang:dis-pmonsyseeprom-s6000
Merged
Fix the continous syseepromd autorestart issue on 201911#4478lguohan merged 2 commits intosonic-net:masterfrom sujinmkang:dis-pmonsyseeprom-s6000
lguohan merged 2 commits intosonic-net:masterfrom
sujinmkang:dis-pmonsyseeprom-s6000
Conversation
jleveque
reviewed
Apr 24, 2020
device/dell/x86_64-dell_s6000_s1220-r0/pmon_daemon_control.json
Outdated
Show resolved
Hide resolved
Collaborator
|
also does this affect 201911 branch? |
Contributor
|
@lguohan, yes, issue was found during 20191130 image testing on Dell S6000 |
Contributor
|
Hi Team, I'll look into this issue. Thanks, |
lguohan
approved these changes
Apr 29, 2020
Contributor
|
Retest vs please |
Contributor
|
Retest vsimage please |
Collaborator
Author
|
Retest vs please |
Collaborator
Author
|
Retest vsimage please |
Collaborator
Author
|
Retest vs please |
sujinmkang
changed the title
sujinmkang
changed the title
abdosi
pushed a commit
that referenced
this pull request
May 1, 2020
- Remove syseepromd from the critical process of pmon docker - Fix supervisor autorestart configuration of syseepromd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
To fix the continuous restart of syseepromd even for the expected exit case.
- How I did it
Remove syseepromd from the critical process of pmon docker
Fix supervisor autorestart configuration of syseepromd
- How to verify it
Start pmon and see if pmon restarts when syseepromd exits with status 0
- Description for the changelog
Before enabling the syseepromd, ensure if def update_eeprom_db(self, e): is implemented for the platform.
Throwing too much error messages and failing to start the syseepromd and causing CPU peak
- A picture of a cute animal (not mandatory but encouraged)