[baseimage]: upgrade base image to debian buster#4405
Merged
lguohan merged 32 commits intosonic-net:masterfrom Apr 20, 2020
Merged
[baseimage]: upgrade base image to debian buster#4405lguohan merged 32 commits intosonic-net:masterfrom
lguohan merged 32 commits intosonic-net:masterfrom
Conversation
lguohan
commented
Apr 9, 2020
lguohan
commented
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
lguohan
commented
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
qiluo-msft
reviewed
Apr 9, 2020
lguohan
force-pushed
the
buster
branch
2 times, most recently
from
c93d645 to
215a2e6
Compare
Collaborator
Author
|
retest broadcom please |
jleveque
reviewed
Apr 10, 2020
jleveque
reviewed
Apr 10, 2020
jleveque
reviewed
Apr 10, 2020
jleveque
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
.../broadcom/sonic-platform-modules-accton/as4630-54pe/modules/x86-64-accton-as4630-54pe-cpld.c
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 10, 2020
platform/broadcom/sonic-platform-modules-accton/as5712-54x/modules/leds-accton_as5712_54x.c
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 10, 2020
jleveque
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
qiluo-msft
reviewed
Apr 10, 2020
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
jleveque
previously approved these changes
Apr 17, 2020
qiluo-msft
previously approved these changes
Apr 17, 2020
Collaborator
Author
|
retest vsimage please |
jleveque
previously approved these changes
Apr 19, 2020
lguohan
force-pushed
the
buster
branch
2 times, most recently
from
6889072 to
83f7e4b
Compare
add $(BLDENV) in cache flags for following targets: - $(SONIC_MAKE_DEBS) - $(SONIC_DPKG_DEBS) - $(SONIC_ONLINE_DEBS) - $(SONIC_COPY_DEBS) - $(SONIC_MAKE_FILES) This is because we could build a same package for both base image and docker which can be different os distribution, i.e., buster v.s. stretch. - target/debs/buster/swig3.0_3.0.12-2_amd64.deb - target/debs/stretch/swig3.0_3.0.12-2_amd64.deb Signed-off-by: Guohan Lu <lguohan@gmail.com>
Kalimuthu-Velappan
approved these changes
Apr 20, 2020
Contributor
Kalimuthu-Velappan
left a comment
Kalimuthu-Velappan
left a comment
There was a problem hiding this comment.
Adding the BLDENV to SONIC_COMMON_FLAGS_LIST would help to resolve the package generation based on the base image type?.
SONIC_COMMON_FLAGS_LIST += $(BLDENV)
Collaborator
Author
Not quite, because other packages such as DOCKER, it does not make a difference whether it is built from buster or stretch. |
qiluo-msft
approved these changes
Apr 20, 2020
jleveque
approved these changes
Apr 20, 2020
Collaborator
|
@lguohan @jleveque I think it also depends on the sonic-utilities PR [201911] Explicitly specify command names with underscores (continued). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
bring up the base image to debian buster 4.19 kernel.
This pr depends on the linux-kernel pr to be merged first.
- How I did it
- How to verify it
build vs image and tested.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)