Skip to content

[docker-orchagent]: Fix qos configuration for TD2 platform#439

Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/fix_qos
Mar 27, 2017
Merged

[docker-orchagent]: Fix qos configuration for TD2 platform#439
pavel-shirshov merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/fix_qos

Conversation

@pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Mar 25, 2017

We must apply buffer configuration before qos configuration

stcheng
stcheng reviewed Mar 25, 2017
View reviewed changes
dockers/docker-orchagent/start.sh
if [ "$HWSKU" == "Force10-S6000" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
SWSSCONFIG_ARGS+="td2.32ports.qos.json td2.32ports.buffers.json "
SWSSCONFIG_ARGS+="td2.32ports.buffers.json td2.32ports.qos.json "
Copy link
Contributor

@stcheng stcheng Mar 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know more information about this. As I don't see any failures while applying the configurations, why the order of applying these files matters? Are there any dependencies in between some SAI objects? How to ensure the order? I think it is better also to fix the dependency in orchagent code.

Copy link
Contributor Author

@pavel-shirshov pavel-shirshov Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by applying buffer configuration after qos configuration we rewrite "PORT_QOS_MAP_TABLE:*: pfc_enable" settings. At least I see there're issues with pfc frame generation.

Sorry. I don't have more information for you.

Do you remember last time I split the buffer/qos configuration files into chunks? sonic-net/sonic-swss@8056a15

I did this because it was just one possibility to make it working. That time you told me we're having bugs in saibcm.

So this time I believe we have some bugs with saibcm too.

Copy link
Contributor

@stcheng stcheng Mar 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will double check. Thanks for the information. Please let me hold this pull request for a moment to investigate.

@pavel-shirshov pavel-shirshov merged commit 70cc499 into sonic-net:master Mar 27, 2017
@pavel-shirshov pavel-shirshov deleted the pavelsh/fix_qos branch March 27, 2017 23:38
@stcheng stcheng mentioned this pull request Mar 28, 2017
Closed
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 21, 2019
@yxieca
[201811 submodules] advance sairedis, swss, swss-common, utilities
2d606f4 
Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (sonic-net#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Feb 21, 2019
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 21, 2019
@yxieca
[201811 utilties] add 201811 branch for sonic-utilities repo
6809e34 
Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Feb 22, 2019
@yxieca
[201811 submodules] advance sairedis, swss, swss-common, utilities (#…
1d11b95 
…2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (#420)
  > [vslib] add missing port attributes for virtual switch (#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (#759)
  > [portsorch] Change speed set flow (#764)
  > Create egress ACL table group during the PFCWD stats list installment (#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (#460)
  > [clock] sync os time to CMOS before rebooting (#465)
  > [intfstat] add intfstat script to output RIF counters (#439)

Signed-off-by: Ying Xie <[email protected]>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (#460)
  > [clock] sync os time to CMOS before rebooting (#465)
  < [sonic_installer] Improve error handling (#460)
  < [clock] sync os time to CMOS before rebooting (#465)
  < [intfstat] add intfstat script to output RIF counters (#439)

Signed-off-by: Ying Xie <[email protected]>
@mykolaf mykolaf mentioned this pull request Feb 22, 2019
Merged
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
617f3d0 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
c4cd84f 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811 submodules] advance sairedis, swss, swss-common, utilities (s…
60f0f4e 
…onic-net#2594)

* [201811 submodules] advance sairedis, swss, swss-common, utilities

Submodule src/sonic-sairedis d57222a..54b02a1:
  > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420)
  > [vslib] add missing port attributes for virtual switch (sonic-net#419)

Submodule src/sonic-swss 584490c..62e2a20:
  > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759)
  > [portsorch] Change speed set flow (sonic-net#764)
  > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787)

Submodule src/sonic-swss-common 286ef34..2592b0c:
  > Add support for WarmStart::setDataCheckState() (#242)

Submodule src/sonic-utilities b44b462..d409987:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  > [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>

* [201811 utilties] add 201811 branch for sonic-utilities repo

Submodule src/sonic-utilities d409987...ff1448c:
  > [sonic_installer] Improve error handling (sonic-net#460)
  > [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [sonic_installer] Improve error handling (sonic-net#460)
  < [clock] sync os time to CMOS before rebooting (sonic-net#465)
  < [intfstat] add intfstat script to output RIF counters (sonic-net#439)

Signed-off-by: Ying Xie <[email protected]>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@mykolaf @liat-grozovik
[intfstat] add intfstat script to output RIF counters (sonic-net#439)
8b6aea1 
* [intfstat] 'add show interface counters rif'

Signed-off-by: Mykola Faryma <[email protected]>

* [rif counters] add unittests

Signed-off-by: Mykola Faryma <[email protected]>

* [setup] add test dependencies packages(mock, mockredipy)

Signed-off-by: Mykola Faryma <[email protected]>

* [intfstat] add alias mode support

Signed-off-by: Mykola Faryma <[email protected]>
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Jan 7, 2021
@qiluo-msft
[sonic-swss-common] Update submodule
2ad522c 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (sonic-net#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (sonic-net#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (sonic-net#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (sonic-net#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (sonic-net#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (sonic-net#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (sonic-net#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (sonic-net#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (sonic-net#435) [Ze Gan]
```
qiluo-msft added a commit that referenced this pull request Jan 8, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (#6382)
5b7f88a 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan]
```
lguohan pushed a commit that referenced this pull request Jan 9, 2021
@qiluo-msft @lguohan
[sonic-swss-common] Update submodule (#6382)
88ace50 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan]
```
mssonicbld added a commit that referenced this pull request Oct 8, 2024
@mssonicbld
[submodule] Update submodule sonic-linux-kernel to the latest HEAD au…
fa9361e 
…tomatically (#20437)

#### Why I did it
src/sonic-linux-kernel
```
* 72616d7 - (HEAD -> 202305, origin/202305) Fix the dps460 kernel driver for the 5.10 kernel (#439) (2 hours ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit to jianyuewu/sonic-buildimage that referenced this pull request May 7, 2025
@ashwnsri
Support for static and dynamic attrs as part of stormond implementati…
cd6a5a4 
…on (sonic-net#439)

* Added support for INNODISK SMART attributes

* Fixed a bug with get_reserved_blocks() function

* Added support for Micron and Intel vendors. Fixed a bug with generic temperature parsing.

* Renamed ssd_base -> storage_base, added class for common calls, modified child class implementation accordingly

* Fixed a looping bug

* renamed sonic_ssd --> sonic_storage, removed 'ssd_' prefix from child classes

* Cleaned up impl per core algorithm changes, defined in HLD

* Renamed SSD and EMMC UTs per naming convention

* Made following changes based on prgeor review coments:

storage_devices.py:
	Moved imports to the beginning of file
	renamed function to _storage_device_object_factory
	Above function now returns an object

storage_common.py:
	Changed logic to only get reads and writes using psutil library.

* Added UTs, fixed bugs in ssd.py surfaced by UTs

* Added more UTs, fixed issue surafced by said UTs

* Increased coverage, cleaned up SsdUtil

* Added more UT coverage

* Addressed review comments, changed UT accordingly

* Increased UT coverage

* Removed the underscore per naming convention

* Fixed the following in ssd.py:

	Changed parse_id_number logic to prevent phantom regex matches
	Fixed a bug in parse_id_number that was causing the code to disregard vendor_ssd_info
	Fixed issues with Innodisk and Virtium parsers
        Fixed a ValueError bug in Virtium parser logic

Added UTs to test the various changes

* Fixed potential issue with parse_id_number not reconciling leading/trailing spaces

* Changed comment to better reflect class intent

* Fixed a bug where stormond was calling a function not defined for EmmcUtil objects

* Fixed fetch_parse_info error on emmc devices

* Added safeguards against vendor utilities failing

* switched from logger to syslogger per review

* Moved log to within class.
mssonicbld added a commit that referenced this pull request Jul 24, 2025
@mssonicbld
[submodule] Update submodule sonic-gnmi to the latest HEAD automatica…
4417414 
…lly (#23453)

#### Why I did it
src/sonic-gnmi
```
* 47a3b00 - (HEAD -> 202405, origin/202405) Merge pull request #439 from liuh-80/dev/liuh/multirole_202405_cp (89 minutes ago) [bingwang-ms]
* 8d9147e - Update server_test.go (2 weeks ago) [Hua Liu]
* c56fb04 - Update server_test.go (2 weeks ago) [Hua Liu]
* 9f1730d - Update clientCertAuth.go (2 weeks ago) [Hua Liu]
* 45cb29c - Update azure-pipelines.yml (2 weeks ago) [Hua Liu]
* eb4d1b1 - Add cert multiple roles support (#366) (2 weeks ago) [Hua Liu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

+1 more reviewer

@stcheng stcheng stcheng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavel-shirshov @lguohan @stcheng