Skip to content

[mellanox]: Enable CPLD update progress bar#4363

Merged
jleveque merged 2 commits intosonic-net:masterfrom
nazariig:master-cpld-progress-bar
Apr 14, 2020
Merged

[mellanox]: Enable CPLD update progress bar#4363
jleveque merged 2 commits intosonic-net:masterfrom
nazariig:master-cpld-progress-bar

Conversation

@nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 3, 2020

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

Summary:

  1. Enabled CPLD update progress bar
  2. Changed cpldupdate invocation: make output realtime

- What I did

  • Enabled CPLD update progress bar

- How I did it

  • Enabled inbuilt cpldupdate progress bar with --print-progress

- How to verify it

  1. Install CPLD FW:
fwutil install chassis component CPLD1 fw /tmp/FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme
  1. Observe progress bar:
New firmware will be installed, continue? [y/N]: y
Installing firmware:
    FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme
                 Lattice Semiconductor Corp.

             ispVME(tm) V12.2 Copyright 1998-2012.

               Customized for Mellanox products.

Using GPIO update!
Processing virtual machine file (FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme)......

... <--- progress bar

- Description for the changelog

  • Added CPLD update progress bar

- A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@volodymyrsamotiy
Copy link
Collaborator

Please add more details to the PR desription according to the listed below:

  • Describe why this change is needed
  • Describe all the changes that were done as part of this PR
    (there is also change of the way how cpldupdate tool is called)
  • Add details to the "How I did it" section
  • Describe verification steps under the "How to verify it" section
  • Add details to the "Description for the changelog" section

stephenxs
stephenxs previously approved these changes Apr 8, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request introduces 1 alert when merging 314ff6bfef4ca3bc186ab032d6176142f1a5f9bd into 7405f8c - view on LGTM.com

new alerts:

  • 1 for Unused import

liat-grozovik
liat-grozovik previously approved these changes Apr 10, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Collaborator Author

@jleveque if no concerns - please help to merge

@jleveque jleveque merged commit 3c4f311 into sonic-net:master Apr 14, 2020
abdosi pushed a commit that referenced this pull request Apr 15, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
mssonicbld added a commit that referenced this pull request Mar 17, 2026
…atically (#26222)

#### Why I did it
src/sonic-utilities
```
* fd161e55 - (HEAD -> 202511, origin/202511) Fix `show ip route json` and `show ipv6 route json` when there is no IPv4 or IPv6 route (#4177) (#4363) (73 minutes ago) [Priyansh]
* 8936c066 - Add FRR failed route check in route_check.py (#4119) (#4362) (3 hours ago) [Priyansh]
* 75978168 - Backport pr4159: Support multi ASIC (#4360) (6 hours ago) [Peter Bailey]
* 1d2c79f1 - config: allow golden config to override mac, platform, asic_id (#4358) (7 hours ago) [mssonicbld]
* 06cd4f2d - [packet manager] Handle enabled/disabled action for generated/transient units (#4359) (7 hours ago) [mssonicbld]
* 5f8c060e - Add fsync to config save to persist config across power cycle (#4353) (9 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants