[docker-syncd-vs]: add support for vs syncd docker auto restart#4344
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 31, 2020
Merged
[docker-syncd-vs]: add support for vs syncd docker auto restart#4344lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Guohan Lu <[email protected]>
jleveque
previously requested changes
Mar 31, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Have you verified that the Supervisor event listener is getting copied properly? I believe you will also need to add a line like the following to docker-syncd-vs.mk:
Collaborator
Author
|
the file is copied in the syncd base container template. |
jleveque
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu [email protected]
- What I did
- How I did it
kill syncd
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)