Skip to content

Add cache build flag #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xumia merged 2 commits into from
Mar 20, 2020
Merged

Add cache build flag #4285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e8727f
Add cache build flag
xumia Mar 17, 2020
4136fd2
Fix bug
xumia Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.cache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
SONIC_COMMON_FILES_LIST := $(if $(wildcard cache.skip.common),, .platform slave.mk rules/functions Makefile.cache)
SONIC_COMMON_FLAGS_LIST := $(CONFIGURED_PLATFORM) \
$(SONIC_DPKG_CACHE_SOURCE) $(SONIC_DEBUGGING_ON) \
$(SONIC_PROFILING_ON) $(SONIC_SANITIZER_ON)
$(SONIC_PROFILING_ON) $(SONIC_SANITIZER_ON) $(ENABLE_SYNCD_RPC)
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENABLE_SYNCD_RPC [](start = 74, length = 16)

which one should use? SONIC_ENABLE_SYNCD_RPC? #Closed

Copy link
Copy Markdown
Collaborator Author

@xumia xumia Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Should follow the same way, using the variable starting with SONIC_

SONIC_BUILD_INSTRUCTION := make
-f slave.mk
BLDENV=$(BLDENV)
.....
*SONIC_ENABLE_SYNCD_RPC=$(ENABLE_SYNCD_RPC) *

Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SONIC_SANITIZER_ON [](start = 52, length = 18)

This is nowhere used. Can we remove? #Closed

Copy link
Copy Markdown
Collaborator Author

@xumia xumia Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

SONIC_COMMON_DPKG_LIST := debian/control debian/changelog debian/rules \
debian/compat debian/install debian/copyright
SONIC_COMMON_BASE_FILES_LIST := sonic-slave-jessie/Dockerfile.j2 sonic-slave-jessie/Dockerfile.user \
Expand Down